Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37437: Pass -Wno-unreachable-code when compiling expat. #14470

Merged
merged 1 commit into from Jun 29, 2019
Merged

bpo-37437: Pass -Wno-unreachable-code when compiling expat. #14470

merged 1 commit into from Jun 29, 2019

Conversation

@benjaminp
Copy link
Contributor

benjaminp commented Jun 29, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue37437
@benjaminp
bpo-37437: Pass -Wno-unreachable-code when compiling expat.
Loading status checks…
eedc015
@benjaminp benjaminp merged commit 95da310 into python:master Jun 29, 2019
4 of 5 checks passed
4 of 5 checks passed
Azure Pipelines PR in progress
Details
bedevere/issue-number Issue number 37437 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jun 29, 2019

Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
@benjaminp benjaminp deleted the benjaminp:no-unreachable-code branch Jun 29, 2019
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jun 29, 2019

Sorry @benjaminp, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 95da310078a9364bae9ab3f2ad9c71e34306a70c 3.8
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jun 29, 2019

GH-14471 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jun 29, 2019
@benjaminp @miss-islington
bpo-37437: Pass -Wno-unreachable-code when compiling expat. (pythonGH…
9cea3f4 
…-14470)

(cherry picked from commit 95da310)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jun 29, 2019

GH-14472 is a backport of this pull request to the 3.6 branch.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jun 29, 2019

Sorry, @benjaminp, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 95da310078a9364bae9ab3f2ad9c71e34306a70c 2.7
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jun 29, 2019
@benjaminp @miss-islington
bpo-37437: Pass -Wno-unreachable-code when compiling expat. (pythonGH…
0176cc8 
…-14470)

(cherry picked from commit 95da310)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
benjaminp added a commit that referenced this pull request Jun 29, 2019
@benjaminp
[3.8] bpo-37437: Pass -Wno-unreachable-code when compiling expat. (GH…
Loading status checks…
6101ed4 
…-14470)

(cherry picked from commit 95da310)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
miss-islington added a commit that referenced this pull request Jun 29, 2019
@miss-islington @benjaminp
bpo-37437: Pass -Wno-unreachable-code when compiling expat. (GH-14470)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ffa419a 
(cherry picked from commit 95da310)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
ned-deily added a commit that referenced this pull request Jun 30, 2019
@miss-islington @benjaminp @ned-deily
bpo-37437: Pass -Wno-unreachable-code when compiling expat. (GH-14470) (
Loading status checks…
a1093e4 
GH-14472)

(cherry picked from commit 95da310)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
ned-deily added a commit to ned-deily/cpython that referenced this pull request Jul 2, 2019
@miss-islington @benjaminp @ned-deily
bpo-37437: Pass -Wno-unreachable-code when compiling expat. (pythonGH…
3e24dd5 
…-14470)

(cherry picked from commit 95da310)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
LorenzMende added a commit to LorenzMende/cpython that referenced this pull request Aug 11, 2019
@benjaminp @LorenzMende
bpo-37437: Pass -Wno-unreachable-code when compiling expat. (pythonGH…
7eda5b8 
…-14470)
lisroach added a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@benjaminp @lisroach
bpo-37437: Pass -Wno-unreachable-code when compiling expat. (pythonGH…
034a2cc 
…-14470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@benjaminp benjaminp

Labels
CLA signed needs backport to 3.8 skip news
Projects
None yet
Milestone
No milestone
4 participants
@benjaminp @miss-islington @bedevere-bot @the-knights-who-say-ni
You can’t perform that action at this time.