Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: fix building with enable_builtin_spellchecker = false #21334
Conversation
4caa9e0
to
ed63c43
11d67a7
to
d3d6ee0
d3d6ee0
to
8d4f101
03824ef
into
master
17 of 19 checks passed
17 of 19 checks passed
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
Nov 30, 2019
|
No Release Notes |
This comment has been minimized.
This comment has been minimized.
|
I was unable to backport this PR to "8-x-y" cleanly; |
This comment has been minimized.
This comment has been minimized.
|
@deepak1556 has manually backported this PR to "8-x-y", please check out #21341 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
miniak commentedNov 29, 2019
Description of Change
Fixes building with
enable_builtin_spellchecker = falseintroduced in #20692Checklist
npm testpassesRelease Notes
Notes: no-notes