Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] bpo-35907, CVE-2019-9948: urllib rejects local_file:// scheme (GH-13474) (GH-13505) #13510

Merged
merged 4 commits into from Jul 14, 2019
Merged

[3.5] bpo-35907, CVE-2019-9948: urllib rejects local_file:// scheme (GH-13474) (GH-13505) #13510

merged 4 commits into from Jul 14, 2019
+22 −1

Conversation

@vstinner
Copy link
Member

vstinner commented May 22, 2019 •
edited by bedevere-bot

CVE-2019-9948: Avoid file reading as disallowing the unnecessary URL
scheme in URLopener().open() and URLopener().retrieve()
of urllib.request.

Co-Authored-By: SH push0ebp@gmail.com
(cherry picked from commit 0c2b6a3)
(cherry picked from commit 34bab21)

https://bugs.python.org/issue35907
@vstinner
bpo-35907, CVE-2019-9948: urllib rejects local_file:// scheme (GH-13474…
Loading status checks…
dbd63ee 
…) (GH-13505)

CVE-2019-9948: Avoid file reading by disallowing local-file:// and
local_file:// URL schemes in URLopener().open() and
URLopener().retrieve() of urllib.request.

Co-Authored-By: SH <push0ebp@gmail.com>
(cherry picked from commit 0c2b6a3)
(cherry picked from commit 34bab21)
@vstinner vstinner force-pushed the vstinner:local_file35 branch from e0a79d3 to dbd63ee May 27, 2019
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented May 27, 2019

I updated the NEWS entry and the commit message.
@larryhastings
Merge branch '3.5' into local_file35
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4bb7086
@larryhastings
Merge branch '3.5' into local_file35
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
61fa1f3
@larryhastings
Merge branch '3.5' into local_file35
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6a6164f
@larryhastings larryhastings merged commit 4fe82a8 into python:3.5 Jul 14, 2019
5 checks passed
5 checks passed
bedevere/issue-number Issue number 35907 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jul 14, 2019

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!
@larryhastings

This comment has been minimized.

Sign in to view
Copy link
Contributor

larryhastings commented Jul 14, 2019

Thanks for the 3.5 love!
@vstinner vstinner deleted the vstinner:local_file35 branch Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@larryhastings larryhastings

Labels
CLA signed type-security
Projects
None yet
Milestone
No milestone
4 participants
@vstinner @bedevere-bot @larryhastings @the-knights-who-say-ni
You can’t perform that action at this time.