Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] closes bpo-38174: Update vendored expat library to 2.2.8. (GH-16346) #16434

Merged
merged 1 commit into from Oct 9, 2019
Merged

[3.5] closes bpo-38174: Update vendored expat library to 2.2.8. (GH-16346) #16434

merged 1 commit into from Oct 9, 2019
+4,919 −5,856

Conversation

@vstinner
Copy link
Member

vstinner commented Sep 27, 2019 •
edited by bedevere-bot

Fixes CVE-2019-15903. See full changelog at https://github.com/libexpat/libexpat/blob/R_2_2_8/expat/Changes.

(cherry picked from commit 52b9408)

https://bugs.python.org/issue38174
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Sep 27, 2019

@larryhastings: Hey, here is a fix for Python 3.5 for https://bugs.python.org/issue38174 :
"Security vulnerability in bundled expat CVE-2019-15903 (fix available in expat 2.2.8)"

cc @benjaminp
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Sep 27, 2019

The Visual Studio project files are modified to remove Modules/expat/loadlibrary.c which has been removed from libexpat 2.2.8. Well, this change is just a backport from the master branch.
@larryhastings

This comment has been minimized.

Sign in to view
Copy link
Contributor

larryhastings commented Sep 28, 2019

I've asked Ned and Julien to look at the Sphinx failure on Travis CI. Hopefully one of 'em will sort it out.
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Oct 1, 2019

I've asked Ned and Julien to look at the Sphinx failure on Travis CI. Hopefully one of 'em will sort it out.

I created https://bugs.python.org/issue38339 to track this bug.
@benjaminp @vstinner
closes bpo-38174: Update vendored expat library to 2.2.8. (GH-16346)
Loading status checks…
184340a 
Fixes CVE-2019-15903. See full changelog at https://github.com/libexpat/libexpat/blob/R_2_2_8/expat/Changes.

(cherry picked from commit 52b9408)
@vstinner vstinner force-pushed the vstinner:expat228_35 branch from bc6a438 to 184340a Oct 8, 2019
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Oct 8, 2019

I rebased my PR on top of the commit edd9bc9 to fix the doc job of Travis CI.
@larryhastings larryhastings merged commit c386c8b into python:3.5 Oct 9, 2019
4 checks passed
4 checks passed
bedevere/issue-number Issue number 38174 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Oct 9, 2019

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!
@larryhastings

This comment has been minimized.

Sign in to view
Copy link
Contributor

larryhastings commented Oct 9, 2019

Thanks for the backport!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@vstinner @larryhastings @bedevere-bot @the-knights-who-say-ni @benjaminp
You can’t perform that action at this time.