Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.4] bpo-30657: Check & prevent integer overflow in PyString_DecodeEscape (GH-2174) #4758

Merged
merged 1 commit into from Dec 8, 2017
Merged

[3.4] bpo-30657: Check & prevent integer overflow in PyString_DecodeEscape (GH-2174) #4758

merged 1 commit into from Dec 8, 2017

Conversation

@hroncok
Copy link
Contributor

@hroncok hroncok commented Dec 8, 2017

Fixes possible integer overflow in PyBytes_DecodeEscape, CVE-2017-1000158.
Original patch by Jay Bosamiya @jaybosamiya in #2174

https://bugs.python.org/issue30657
@hroncok @jaybosamiya
bpo-30657: Fix CVE-2017-1000158
e3e119a 
Fixes possible integer overflow in PyBytes_DecodeEscape.

Co-Authored-By: Jay Bosamiya <jaybosamiya@gmail.com>
@hroncok hroncok mentioned this pull request Dec 8, 2017
Merged
vstinner
vstinner approved these changes Dec 8, 2017
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM.

@vstinner
Copy link
Member

@vstinner vstinner commented Dec 8, 2017

@larryhastings: Would you mind to merge this PR?

@larryhastings larryhastings merged commit 6c004b4 into python:3.4 Dec 8, 2017
4 checks passed
@hroncok hroncok deleted the 3.4-fix-issue-30657 branch Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

Assignees
No one assigned
Labels
CLA signed type-bugfix
Projects
None yet
Milestone
No milestone
5 participants
@hroncok @vstinner @larryhastings @the-knights-who-say-ni @bedevere-bot