Fix for Install-PSResource always reinstall issue #525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
PR Summary
This PR fixes the 'always reinstall and restore on fail issue' of Issue #498, and also updates the build version to the next release (beta12). This PR also includes some general code clean up.
PR Context
Install-PSResourcewas always reinstalling modules even though-Reinstallswitch was not selected. This is because the code was not correctly removing 'already installed' packages from the 'toinstall' list.Also, if a reinstall fails because one of the files is locked (as can happen with loaded .NET binaries) then an error message is emitted and the original resource module files are restored.
Unused variables and parameter arguments were removed.
Some minor code refactoring and method renaming for better clarity.
Added some code regions where they were missing.
Alphabetized using statements per code style guidelines.
Upped module version to 3.0.12 beta.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.The text was updated successfully, but these errors were encountered: