Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUnify the repository list and URL tabs in the clone dialog #2197
+217
−194
Conversation
jcansdale
added some commits
Jan 23, 2019
meaghanlewis
referenced this pull request
Jan 23, 2019
Closed
Development sprint: February 25th release #2178
jcansdale
added some commits
Jan 28, 2019
jcansdale
changed the title
[wip] Unify the repository list and URL tabs
Unify the repository list and URL tabs
Jan 29, 2019
jcansdale
requested review from
grokys and
meaghanlewis
Jan 29, 2019
jcansdale
added
Ready for Review
enhancement
labels
Jan 29, 2019
This comment has been minimized.
This comment has been minimized.
|
This looks good to me functionality wise. |
meaghanlewis
added
the
verified
label
Jan 31, 2019
jcansdale
requested a review
from StanleyGoldman
Feb 1, 2019
StanleyGoldman
approved these changes
Feb 1, 2019
This comment has been minimized.
This comment has been minimized.
|
Looks good. What about that last todo? |
This comment has been minimized.
This comment has been minimized.
|
We will also need to update the documentation for this unified dialog here: https://github.com/github/VisualStudio/blob/master/docs/using/cloning-a-repository-to-visual-studio.md#clone-repositories. I'm happy to do that. |
jcansdale
added some commits
Feb 4, 2019
jcansdale
deleted the
fixes/2187-unify-repository-list-tabs
branch
Feb 5, 2019
meaghanlewis
changed the title
Unify the repository list and URL tabs
Unify the repository list and URL tabs in the clone dialog
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jcansdale commentedJan 23, 2019
•
edited
It appears users rarely change the tab they're initially presented with. This is despite the fact that the different tabs are useful in different circumstances. If the user is cloning a repository they own or have contributed to, the GitHub/GitHub Enterprise tab makes sense. If they're cloning a public repository owned by a different user, it would be necessary to use the URL tab.
What this PR does
This PR combines the repository list and URL tabs so that a user can clone any repository without needing to understand the difference between tabs.
/or.gitURLtabTo do
/or.gitwhen searchingHow to test
Finding a repository by its URL
File > Open > Open from GitHub...Search or enter a URLYour repositoriessectionCloning a public repository by its URL
File > Open > Open from GitHub...Search or enter a URLClonebutton is clickableRe-cloning a repository
File > Open StartPagehttps://link underRecentSearch or enter a URLboxCloning a GitHub Enterprise repository by its URL
File > Open > Open from GitHub...Search or enter a URLboxWhat this PR doesn't do
What if the user has already logged into a GitHub/Enterprise account, but not the one they they want to clone from? At the moment they would need to open
Team Explorer - Connectand sign out/sign in to the correct account. This isn't very discoverable.This is out of scope for this PR since it also wasn't possible with the previous implementation. Should we offer an explicit login/sign out option in another PR?
It would be nice if we could automatically check that a repository exists when the user enters a URL. The repository could be automatically added to a section called something like
Public repositories.Alternatively, we could automatically fire off a search and supplement the repository list when the user starts entering a query. This would allow users to find public repositories they about without visiting github.com.
We can easily see if a repository has been starred, but we don't currently surface this information. This is likely a useful signal when scanning for a repository in a potentially long list.
Fixes #2187