Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Ensure x86|x64\e_sqlite3.dll are included in .vsix #2098
Merged
Conversation
Ensure e_sqlite.dll is included in .vsix when built using Visual Studio. This file was only being included in the .vsix when built using MSBuild from the command line.
Explicitly include x86\e_sqlite3.dll and x64\e_sqlite3.dll from content files in VSIX.
A direct reference to this package causes x86\e_sqlite3.dll and x64\e_sqlite3.dll be copied to the output directory so they can be picked by the VSIXSourceItem filter.
85e981a
to
7868846
|
@madskristensen i'm seeing a strange issue where artifacts are appearing in .vsix depending on whether is's build from the command line with MSBuild or from inside Visual Studio. When built using Visual Studio the |
|
@dgriffen Do you know? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ensure
e_sqlite.dllis included in .vsix when built using Visual Studio. This file was only being included in the .vsix when built using MSBuild from the command line.I don't like how brittle this is, but it was the only way I could find to ensure that
x86|x64\e_sqlite3.dllare included in .vsix when built using Visual Studio.What this PR does
<PackageReference Include="SQLitePCL.raw_basic">toGitHub.VisualStudio.csprojHow to test
GitHub.VisualStudio.vsixcontainsx86\e_sqlite3.dllandx64\e_sqlite3.dll(you can view contents using 7-zip)What was happening
Here is a comparison between a .vsix build using Visual Studio and one build using MSBuild from the command line.
It was causing the following when attempting to view a PR file diff.
Notes
I'm hoping it was also the reason some buttons weren't showing up.🤞 We'll need to keep a look out for this one!