Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix for Visual Studio 2019 Preview #2014
Merged
Conversation
These are required for Visual Studio 2019 support.
There are assemblies with exactly the same IAsyncServiceProvider namespace + name. Change to use IServiceProvider instead to avoid having to use assembly aliases. These were getting more complication with the introduction of Visual Studio 2019 support.
The ServiceProgressData type is in a Visual Studio 2019 assembly that we don't currently have access to. Using reflection to call the CloneAsync in order to avoid conflicts with the Visual Studio 2017 version. Progress won't be displayed on the status bar, but it appears prominently on the Team Explorer Home view.
Create a GitHub.TeamFoundation.16 project that will install and execute inside Visual Studio 2019.
|
Double clicking a repository on the connect list brings up the Update: Fixed! |
Stop the `How would you like to get started?` dialog from appearing when a repository is double clicked on. Convert GitHubConnectSection to use ITeamExplorerServices.OpenRepository instead of IVSServices.TryOpenRepository to change repository context. This method knows how to change context for Visual Studio 2015, 2017 and 2019.
BrowsesToTheCorrectURL was already being ignored but is now failing to compile.
Codecov Report
@@ Coverage Diff @@
## master #2014 +/- ##
==========================================
- Coverage 39.16% 38.03% -1.13%
==========================================
Files 405 372 -33
Lines 17343 16099 -1244
Branches 2398 2216 -182
==========================================
- Hits 6793 6124 -669
+ Misses 10016 9538 -478
+ Partials 534 437 -97
|
|
This looks great to me! Tested in VS2015, 2017 and 2019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR does the required changes to make the extension play nicely with Visual Studio 2019 Preview.
GitHub.TeamFoundation.16project (Team Explorerextension)IGitActionsExt.CloneAsyncto be called from Visual Studio 2019 (required a little reflection)ITeamExplorerServices.OpenRepositoryrather thanIVSServices.TryOpenRepositoryMicrosoft.TeamFoundation.*v16 assemblies tolibfolderIServiceProviderrather thanIAsyncServiceProvidertoVSGitExt(avoiding type name collisions)GraphsNavigationItemTests, which were previously ignored but now not compilingHow to test
This PR has touched the code responsible for cloning a repository and for opening an already cloned repository. We should check this functionality on Visual Studio 2015, 2017 and 2019.
Check Cloning a Repository
File > Open > Open from GitHub...CloneTeam Explorer - Homeappear with clone processSolution Explorerpane has target repository folder openCheck Opening a Repository
Team > Manager Connections...GitHub/ GHETeam Explorer - Homeopens with target repositorySolution ExplorerpanePossible issues
I believe the issue from #1859 is back in Visual Studio 2019 Preview, but I've heard this should be fixed in the public release. This shouldn't happen every time you install, but it's something to watch out for!