Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't leave comment on deleted line #2166

Closed
jcansdale opened this issue Jan 9, 2019 · 0 comments
Closed

Can't leave comment on deleted line #2166

jcansdale opened this issue Jan 9, 2019 · 0 comments
Labels
bug
Milestone
2.7.0

Comments

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Jan 9, 2019

Versions

  • GitHub Extension for Visual Studio version: 2.7.0 (dev)
  • Visual Studio version: 2017

What happened

  1. I tried to leave a comment on the deleted line 134 of RepositoryCreationViewModel.cs PR #2165
  2. The inline comment UI appears but is empty

image

Expected behavior

Expected inline comment box to appear like it does on the RHS.

image
grokys added a commit that referenced this issue Jan 9, 2019
@grokys
Fix AvailableForComment calculation.
Loading status checks…
6630f2d 
When showing a comment peek view on the LHS of the diff view, we need to look at `OldLineNumber` instead of `NewLineNumber` to calculate `AvailableForComment`.

Fixes #2166
@grokys grokys mentioned this issue Jan 9, 2019
Merged
@meaghanlewis meaghanlewis added this to the 2.6.3 milestone Jan 11, 2019
@jcansdale jcansdale added the bug label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
  2.7.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@meaghanlewis @jcansdale
You can’t perform that action at this time.