Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd missing YAML files to .gitattributes #998
Conversation
|
Cooooooooooooooool There are more (or so Unity peeps tell me), but the only way to know is to scrape the Unity source (or so Unity peeps tell me), so yay this is a great start! |
|
@shana So, I kinda took a look at the Unity source code I extracted all the extensions in the Here's a JSON file that has the differences between all 3 repos: gist Now, if we look at just the Unity-specific extensions that we don't have here, the list is short: And these ones in the template repo: Otherwise, there is quite a lot of difference... In the Unity source code, there are more extensions for file types like images, video files, etc. We can ignore them or add some of them. (Not all of them are commonly used) Also, there are extensions that we have but the Unity source code doesn't contain, which is concerning Anyway, do you think adding any of these extensions is worthwhile? If so, should I open a PR here or in the new repo? Thanks! |

FurkanKambay commentedJan 8, 2019
•
edited by shana
Fixes #847
(The generated) .gitattributes file was missing some other YAML files besides
.prefab,.unity, etc.I created an empty project and created almost everything under
Assets/Create. Here are the files: https://i.imgur.com/QODfnOr.pngWhile I'm not familiar with a lot of these extensions, Unity supports them, so they should be in .gitattributes.