Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate the generated .gitignore #992
Conversation
|
This looks great, thank you so much! Sorry for the delay in the review, the holidays always get in the way... I did a couple of tweaks to your branch, everything looks great. As for the crashalytics line, I don't know what it is, but looking at examples like https://github.com/auth0/sharelock-android/blob/master/app/src/main/assets/crashlytics-build.properties on the internets, looks like it's something that shouldn't be committed to source control. It's not always in StreamingAssets though, so the ignore should probably just be the filename |
|
|
c34d0c1
into
github-for-unity:master
|
@shana No worries! And thanks for the other changes. |
FurkanKambay commentedDec 28, 2018
•
edited
Description of the Change
Updated the
.gitignorethat gets generated when initializing the repo. I copied from Unity.gitignore in github/gitignore.To go over the changes top-to-bottom:
.gitignoreis at the root of the repo anywayLogs/(github/gitignore#2912).gradle/(github/gitignore#2906)*.opendb(github/gitignore#2681)*.VC.db(github/gitignore#2847)*.pdb.meta(github/gitignore#2486)Also there was another change about Crashlytics, but I didn't include it. Tell me if you want it.