Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the standalone api nicer to use #989

Merged
merged 9 commits into from Jan 23, 2019
Merged

Making the standalone api nicer to use #989

merged 9 commits into from Jan 23, 2019

Conversation

@shana
Copy link
Contributor

shana commented Dec 21, 2018

I did a little app (https://github.com/shana/unity-runtime-git) to test using the api at runtime, and I had to do some tweaks to make it nicer to use. These are those tweaks:

  • When parsing the history log, the first line of the commit was being added to the description. This makes it annoying to show entries when showing both the first line (summary) and the body (description), as the first line would appear duplicated. I kinda wanna treat these as email subject and body (because that's what they were meant to be originally in git anyways), so took out the duplication.
  • calling InitializeRepository(path to repository) on DefaultEnvironment does the useful thing of setting the base path on the FileSystem object, which means any shell commands and path manipulations are going to assume that path to repository as the base for all relative paths and working directory paths. Which is handy! Only the logic that we currently have makes it impossible to call InitializeRepository twice (it just ignores it), so it's not easy to switch these paths.
  • The task classes should be public, they're useful!
@shana shana requested a review from StanleyGoldman Dec 21, 2018
Copy link
Member

StanleyGoldman left a comment

Looks good, otherwise one nit pick.

@shana shana force-pushed the fixes/api branch from 829e838 to d3349ce Jan 9, 2019
@StanleyGoldman StanleyGoldman dismissed their stale review Jan 23, 2019

Fixed?

shana and others added 2 commits Jan 23, 2019
Removing newline processed from LogEntryOutputProcessor
@StanleyGoldman StanleyGoldman merged commit 5defe7b into master Jan 23, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@StanleyGoldman StanleyGoldman deleted the fixes/api branch Jan 23, 2019
@github-for-unity github-for-unity deleted a comment Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.