Skip to content

/ Unity

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlays in asset explorer only show for repositories with a remote #910

Closed
meaghanlewis opened this issue Sep 17, 2018 · 0 comments
Closed

Overlays in asset explorer only show for repositories with a remote #910

meaghanlewis opened this issue Sep 17, 2018 · 0 comments
Assignees
@StanleyGoldman
Labels
bug

Comments

@meaghanlewis
Copy link
Contributor

@meaghanlewis meaghanlewis commented Sep 17, 2018 •
edited

Description

Steps to Reproduce

  1. Create a new Unity project and initialize the GitHub extension
  2. Initialize the project
  3. Add some new assets to the project
  4. Open the Project view and look under assets.

Expected behavior:
Overlay on new or modified assets should appear.

Actual behavior:
The overlay does not appear on assets without a remote.

screen shot 2018-09-17 at 11 41 37 am

The piece of code that needs to be fixed is here:

Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs

Lines 29 to 44 in 484d6a9

private static bool IsInitialized { get { return Repository != null && Repository.CurrentRemote.HasValue; } }
public static void Initialize(IApplicationManager theManager)
{
EditorApplication.projectWindowItemOnGUI -= OnProjectWindowItemGUI;
EditorApplication.projectWindowItemOnGUI += OnProjectWindowItemGUI;
manager = theManager;
if (IsInitialized)
{
Repository.StatusEntriesChanged += RepositoryOnStatusEntriesChanged;
Repository.LocksChanged += RepositoryOnLocksChanged;
ValidateCachedData();
}
}

@StanleyGoldman StanleyGoldman mentioned this issue Sep 17, 2018
Merged
@StanleyGoldman StanleyGoldman self-assigned this Sep 17, 2018
@StanleyGoldman StanleyGoldman added the bug label Sep 17, 2018
@sguthals sguthals mentioned this issue Oct 10, 2018
Closed
6 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StanleyGoldman StanleyGoldman

Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@StanleyGoldman @meaghanlewis
You can’t perform that action at this time.