Update Node.gitignore #2934
Merged
Update Node.gitignore #2934
Conversation
|
@byeonggukgong thanks! |
Ortega-Dan
added a commit
to Ortega-Dan/gitignore
that referenced
this pull request
Jun 26, 2019
* Update Node.gitignore * Fix coverage.lcov to *.lcov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Reasons for making this change:
It need
coverage.lcovfile to integrate nyc and Codecov. I recommend to add it because it's created locally when someone will check that the node command that creatingcoverage.lcovfile works correctly.Links to documentation supporting these rule changes:
https://github.com/istanbuljs/nyc#integrating-with-codecov