Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: use internal/errors #14009

Closed
wants to merge 2 commits into from
Closed

child_process: use internal/errors #14009

wants to merge 2 commits into from

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Jun 30, 2017 •
edited

Refs: #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

child_process
@tniessen
child_process: use internal/errors
Loading status checks…
483d245
@tniessen
Copy link
Member Author

@tniessen tniessen commented Jun 30, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8901/
@tniessen tniessen added the errors label Jun 30, 2017
@refack
refack approved these changes Jun 30, 2017
View changes
@tniessen tniessen self-assigned this Jun 30, 2017
@jasnell jasnell mentioned this pull request Jun 30, 2017
Closed
79 of 80 tasks complete
@jasnell
jasnell approved these changes Jun 30, 2017
View changes
@Trott Trott added the semver-major label Jun 30, 2017
@lpinca
lpinca reviewed Jul 1, 2017
View changes
lib/internal/child_process.js Outdated
@@ -545,7 +551,8 @@ function setupChannel(target, channel) {
options = undefined;
} else if (options !== undefined &&
(options === null || typeof options !== 'object')) {
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'options', 'Object');
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'options', 'Object',

This comment has been minimized.

Sign in to view
@lpinca

lpinca Jul 1, 2017
Member

Why is 'Object' capitalized here?

This comment has been minimized.

Sign in to view
@tniessen

tniessen Jul 1, 2017
Author Member

It was like that before, should I change it?

This comment has been minimized.

Sign in to view
@lpinca

lpinca Jul 1, 2017
Member

Yeah I noticed but few lines above (260) it is in lowercase. I'd make them consistent.
@tniessen
Fix capitalization
81f13fb
@tniessen
Copy link
Member Author

@tniessen tniessen commented Jul 2, 2017

@nodejs/ctc due to semverity
@lpinca
lpinca approved these changes Jul 2, 2017
View changes
@mcollina
mcollina approved these changes Jul 2, 2017
View changes
Copy link
Member

@mcollina mcollina left a comment

LGTM as semver-major
@targos
targos approved these changes Jul 3, 2017
View changes
tniessen added a commit that referenced this pull request Jul 3, 2017
@tniessen
child_process: use internal/errors
fe730d3 
PR-URL: #14009
Refs: #11273
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@tniessen
Copy link
Member Author

@tniessen tniessen commented Jul 3, 2017

Landed in fe730d3. CI on master: https://ci.nodejs.org/job/node-test-commit-linuxone/7044/
@tniessen tniessen closed this Jul 3, 2017
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina

@refack refack

@jasnell jasnell

@lpinca lpinca

@targos targos

Assignees

@tniessen tniessen

Labels
child_process errors semver-major
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@tniessen @mcollina @refack @jasnell @lpinca @targos @Trott @nodejs-github-bot
You can’t perform that action at this time.