Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
errors, url: port url errors to internal/errors #13963
Closed
Conversation
|
CI: https://ci.nodejs.org/job/node-test-pull-request/8857/ Don't worry if node-test-commit-linux doesn't pass. The CI bot has had some trouble recently. |
test/parallel/test-url-format-invalid-input.js
Outdated
| code: 'ERR_INVALID_ARG_TYPE', | ||
| type: TypeError, | ||
| message: 'The "urlObj" argument must be of type object. ' + | ||
| `Received type ${type}` |
jasnell
Jun 29, 2017
Member
nit: line up the strings here.
nit: line up the strings here.
starkwang
Jun 29, 2017
Author
Contributor
fixed
fixed
test/parallel/test-url-parse-invalid-input.js
Outdated
| }); | ||
|
|
||
| assert.throws(() => { url.parse('http://%E0%A4%A@fail'); }, | ||
| /^URIError: URI malformed$/); | ||
| assert.throws(() => { url.parse('http://%E0%A4%A@fail'); }, /^URIError: URI malformed$/); |
jasnell
Jun 29, 2017
Member
long line here?
long line here?
starkwang
Jun 29, 2017
Author
Contributor
OK, I fix it.
OK, I fix it.
|
LGTM |
refack
added a commit
to refack/node
that referenced
this pull request
Jul 2, 2017
PR-URL: nodejs#13963 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 473f0ef |
|
Extra sanity run on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
There is already a PR (#11360) for this migration, but it seems to be out-of-date and deprecated. So I make a new one.
Ref: #11273
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url, test