Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix max length on stream.md #19169

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@joyeecheung joyeecheung

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
doc dont-land-on-v6.x dont-land-on-v8.x fast-track stream
Projects
None yet
Milestone
No milestone
4 participants
@mcollina @joyeecheung @BridgeAR @nodejs-github-bot
@mcollina
Copy link
Member

mcollina commented Mar 6, 2018

See: #18438

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@mcollina
doc: fix max length on stream.md 
See: #18438
Loading status checks…
fff2c8b

@mcollina mcollina added doc fast-track labels Mar 6, 2018

@nodejs-github-bot nodejs-github-bot added doc stream labels Mar 6, 2018

@joyeecheung

joyeecheung approved these changes Mar 6, 2018
View changes

@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member

joyeecheung commented Mar 6, 2018

Linter CI: https://ci.nodejs.org/job/node-test-pull-request-lite/225/
@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

mcollina commented Mar 6, 2018

LINT CI: https://ci.nodejs.org/job/node-test-linter/16732/

@joyeecheung joyeecheung added dont-land-on-v4.x dont-land-on-v6.x dont-land-on-v8.x labels Mar 6, 2018

@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member

joyeecheung commented Mar 6, 2018

CI is green
@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

mcollina commented Mar 6, 2018

landing
@BridgeAR

BridgeAR approved these changes Mar 6, 2018
View changes

@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

mcollina commented Mar 6, 2018

Landed in 1a5ec83

@mcollina mcollina closed this Mar 6, 2018

@mcollina mcollina deleted the mcollina:fix-markdown-linting-stream branch Mar 6, 2018

mcollina added a commit that referenced this pull request Mar 6, 2018

@mcollina
doc: fix max length on stream.md 
See: #18438

PR-URL: #19169
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1a5ec83

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

@mcollina @MayaLekova
doc: fix max length on stream.md 
See: nodejs#18438

PR-URL: nodejs#19169
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
adc9ba4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.