bpo-35959: Fix division by 0 when checking for overflow #11808
Conversation
|
This fix the issue, do you think we still need to consume the whole iterable thought? Maybe we could break early? |
If something like ('nan') appear afterwards, the result need to be ('nan') so we cannot break earlier. |
|
You're right, thanks. |
| @@ -1756,6 +1756,10 @@ def test_prod(self): | |||
| with self.assertRaises(TypeError): | |||
| prod([10, 20], [30, 40]) # start is a keyword-only argument | |||
|
|
|||
| self.assertEqual(prod([0, 1, 2, 3]), 0) | |||
| self.assertEqual(prod([1, 0, 2, 3]), 0) | |||
There was a problem hiding this comment.
[1, 2, 3, 0] was already working fine without this fix so is it worth adding this as a test case? I have less knowledge with C so please ignore if this is not needed.
self.assertEqual(prod([1, 2, 3, 0]), 0)
There was a problem hiding this comment.
I have added this test and removed the range base one. Even if that case worked fine because it takes a different code path, I like to have the 0 in the start/middle/end.
Thanks for the catch!
|
@tirkarthi Thanks to you for finding the bug! :) |
https://bugs.python.org/issue35959