Skip to content

/ Unity

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloader hangs when executed with no items #877

Merged
merged 5 commits into from Aug 1, 2018
Merged

Downloader hangs when executed with no items #877

merged 5 commits into from Aug 1, 2018

Conversation

@StanleyGoldman
Copy link
Member

StanleyGoldman commented Jul 31, 2018 •
edited

Might be related to: #841

Depends on:

Testing local builds, where the conditions for downloading resources are slightly different.
I found an issue where the Downloader will hang when RunSynchronously is called with no items in the queue.

Unity/src/GitHub.Api/Installer/GitInstaller.cs

Lines 260 to 264 in 675714a

if (!state.GitZipExists && !state.GitIsValid && state.GitPackage != null)
downloader.QueueDownload(state.GitPackage.Uri, installDetails.ZipPath);
if (!state.GitLfsZipExists && !state.GitLfsIsValid && state.GitLfsPackage != null)
downloader.QueueDownload(state.GitLfsPackage.Uri, installDetails.ZipPath);
downloader.RunSynchronously();

It hangs because TrySetResult/TrySetException is never called.
@StanleyGoldman
Preventing queue execution if no items are added
Verified
This commit was signed with a verified signature.
StanleyGoldman Stanley Goldman
GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
Loading status checks…
675714a
@StanleyGoldman
Merge branch 'fixes/branch-list-test-ci-ignore' into fixes/empty-task…
Verified
This commit was signed with a verified signature.
StanleyGoldman Stanley Goldman
GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
Loading status checks…
1ea7925 
…-queue
@StanleyGoldman
Merge branch 'master' into fixes/empty-task-queue
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e7c2a8c
@StanleyGoldman
Merge branch 'master' into fixes/empty-task-queue
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ac93c49
@StanleyGoldman StanleyGoldman mentioned this pull request Aug 1, 2018
Closed
@StanleyGoldman
Making sure to call base methods appropriately
Verified
This commit was signed with a verified signature.
StanleyGoldman Stanley Goldman
GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
Loading status checks…
801d033
@StanleyGoldman StanleyGoldman force-pushed the fixes/empty-task-queue branch from c2df2a5 to 801d033 Aug 1, 2018
@shana shana merged commit d586e14 into master Aug 1, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@shana shana deleted the fixes/empty-task-queue branch Aug 1, 2018
@sguthals sguthals mentioned this pull request Oct 10, 2018
Closed
6 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@StanleyGoldman @shana
You can’t perform that action at this time.