Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSpool files in GitClient.Remove() method to prevent possible issues #905
Conversation
…hen trying to remove lots of files;
484d6a9
into
github-for-unity:master
1 check passed
1 check passed
|
Thanks @KonH for picking up that spare for us. Can I ask a question? |
|
Docs are clear and understandable, I didn't have problems with them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
KonH commentedSep 3, 2018
Description of the Change
Spool files in GitClient.Remove() method to prevent possible issues when trying to remove lots of files (similar to other methods logics).
Alternate Designs
No other alternatives (except no changes in code).
Benefits
More efficient delete of large count of files.
Possible Drawbacks
Don't know about it, looks like suitable change similar to other methods.
Applicable Issues
Relates and described here - #887