Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make avatar in PR review summary clickable. #1586

Merged
merged 1 commit into from Apr 10, 2018
Merged

Make avatar in PR review summary clickable. #1586

merged 1 commit into from Apr 10, 2018

Conversation

@grokys
Copy link
Contributor

@grokys grokys commented Apr 5, 2018 •
edited

Addresses this request in #1570:

Could we make it so you can click on either the avatar or the ✔️ / 💬? #1523 (comment)

This makes the avatar in the "Reviewers" section clickable; when clicked it navigates to the user's reviews:

image

Depends on #1585
Part of #1491
@grokys
Make avatar in PR review summary clickable.
Loading status checks…
02427b6
This was referenced Apr 5, 2018
Merged
Closed
@donokuda
donokuda approved these changes Apr 5, 2018
View changes
Copy link
Member

@donokuda donokuda left a comment

I reviewed the changes in 02427b6 and it looks good to me.

Also pulled it down and tested the branch locally 👍
@meaghanlewis
Copy link
Contributor

@meaghanlewis meaghanlewis commented Apr 5, 2018

LGTM 👍
@jcansdale jcansdale changed the base branch from feature/pr-reviews-master to feature/pr-reviews Apr 10, 2018
@jcansdale jcansdale changed the base branch from feature/pr-reviews to feature/pr-reviews-master Apr 10, 2018
@jcansdale
jcansdale approved these changes Apr 10, 2018
View changes
@jcansdale jcansdale merged commit cef9124 into feature/pr-reviews-master Apr 10, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jcansdale jcansdale deleted the fixes/make-review-avatar-clickable branch Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donokuda donokuda

@jcansdale jcansdale

@StanleyGoldman StanleyGoldman

@sguthals sguthals

@meaghanlewis meaghanlewis

Assignees
No one assigned
Labels
verified
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@grokys @meaghanlewis @donokuda @jcansdale
You can’t perform that action at this time.