Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Make Navigate to Editor more discoverable #1552
+58
−6
Conversation
jcansdale
requested a review
from
sguthals
Mar 21, 2018
jcansdale
referenced this pull request
Mar 22, 2018
Closed
[spike] Feature inline comments in editor #1559
jcansdale
added some commits
Apr 10, 2018
jcansdale
changed the base branch from
master
to
feature/pr-reviews-master
Apr 10, 2018
jcansdale
added some commits
Apr 10, 2018
jcansdale
added
the
Ready for Review
label
Apr 11, 2018
meaghanlewis
added this to In progress
in 2.4.4
Apr 13, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
meaghanlewis
Apr 13, 2018
Contributor
Have been dogfooding this and I think the message is helpful. It's not at all distracting, because the bar is always there- I'm just used of it only saying Ready.
|
Have been dogfooding this and I think the message is helpful. It's not at all distracting, because the bar is always there- I'm just used of it only saying |
meaghanlewis
added
the
verified
label
Apr 13, 2018
jcansdale
merged commit c2b105e
into
feature/pr-reviews-master
Apr 16, 2018
2.4.4
automation
moved this from In progress
to Done
Apr 16, 2018
jcansdale
deleted the
fixes/1546-make-navigate-to-editor-discoverable
branch
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jcansdale commentedMar 21, 2018
•
edited
Edited 12 times
-
jcansdale
edited Apr 16, 2018
-
jcansdale
edited Apr 10, 2018
-
jcansdale
edited Apr 10, 2018
-
jcansdale
edited Apr 10, 2018
-
jcansdale
edited Apr 10, 2018
-
jcansdale
edited Mar 29, 2018
-
jcansdale
edited Mar 29, 2018
-
jcansdale
edited Mar 29, 2018
-
jcansdale
edited Mar 21, 2018
-
jcansdale
edited Mar 21, 2018
-
jcansdale
edited Mar 21, 2018
-
jcansdale
edited Mar 21, 2018
What this PR does
This PR gives users a hint that the Navigate to Editor functionality exists.
It adds the following messages:
When a PR file diff gets focus
When a PR file diff gets focus from a PR that isn't checked out
When user attempts to navigate to a file that isn't checked out
When the diff file focus is lost the status is cleared (showing the default
Readymessage)View Fileto view a (read-only) PR fileReviewers
Todo
Finalize the wording. Would something like this be better?Press Enter to navigate to Editor (PR branch must be checked out)It would be nice if the dialog gaveCheckoutandCanceloptionsMaybe do this ina separate PRPart of #1491
Fixes #1546