Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Display PR review comments inline. #1549
Conversation
When the user clicks a review comment represented by a `PullRequestReviewFileCommentViewModel`, open the comment inline in a diff view.
|
@grokys one thing I found interesting is that I couldn't get a diff view (the 3rd one) to open while reviewing comments.
|
|
I also found it interesting that for comment reviews, the comment is displayed as a Description versus comments or outdated comments. Could comment reviews just be called comments?
|
|
I think this is because there are two separate concepts here:
|
|
Cool, thanks for clarifying the description comments @grokys. The only other interesting thing was that a diff didn't open for one comment (I pointed out a few days ago. The example comes from PR 1492). I initially thought it had to do with the file extension, but don't think that's the case. I noticed that the diff I want to open isn't rendered by default in dotcom: So I'm thinking that diff won't open because it's just a really large diff. Don't know how commonly this happens but might be worth it to show something in VS to indicate why the diff doesn't open. |
Can you clarify this? I have a ton of reviews/comments on this one file: However, it is working, when I click on a comment in the review in the pane it opens it up in the diff view. Two things that might be out of scope or things we cannot fix:
|
…ew-comments-in-editor
When the user clicks a review comment represented by a
PullRequestReviewFileCommentViewModel, open the comment inline in a diff view:This also handles showing outdated comments in a diff representing the commit at which the comment was left. Doing this required a few changes to the inline comment/PR session manager classes to make them accept a commit SHA instead of just assuming that the PR head will be needed.
Depends on #1545
Part of #1491