Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update octokit to 0.29.0 #1521

Merged
merged 3 commits into from Mar 28, 2018
Merged

Conversation

@grokys
Copy link
Contributor

@grokys grokys commented Mar 6, 2018

The PR reviews feature needs an updated octokit. This PR updates our octokit to the latest release 0.29.0.

Depends on #1501
Depends on editor-tools/octokit.net#4
Part of #1491

@grokys grokys requested review from shana, StanleyGoldman and jcansdale Mar 6, 2018
@shana shana changed the base branch from feature/pr-reviews-master to feature/graphql-modelservice-pr-reviews Mar 9, 2018
@shana shana changed the base branch from feature/graphql-modelservice-pr-reviews to feature/pr-reviews-master Mar 9, 2018
@shana shana changed the base branch from feature/pr-reviews-master to feature/graphql-modelservice-pr-reviews Mar 9, 2018
@shana
shana approved these changes Mar 9, 2018
@meaghanlewis meaghanlewis added this to To do in 2.4.4 via automation Mar 12, 2018
@grokys grokys force-pushed the feature/graphql-modelservice-pr-reviews branch from c649c25 to 0a20262 Mar 19, 2018
grokys added 2 commits Feb 21, 2018
This is integrated a bit hackily into `ModelService`; `ModelService` doesn't really mesh well with GraphQL but without a lot of refactoring this was the best way to get things up and running.
@grokys grokys force-pushed the update/octokit-to-0.29.0 branch from 9349655 to 9353f41 Mar 19, 2018
@grokys grokys changed the base branch from feature/graphql-modelservice-pr-reviews to feature/pr-reviews-master Mar 19, 2018
@grokys grokys requested review from sguthals and meaghanlewis Mar 23, 2018
@jcansdale jcansdale changed the base branch from feature/pr-reviews-master to feature/pr-reviews Mar 28, 2018
@jcansdale jcansdale changed the base branch from feature/pr-reviews to feature/pr-reviews-master Mar 28, 2018
@jcansdale jcansdale merged commit f75bea3 into feature/pr-reviews-master Mar 28, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
2.4.4 automation moved this from To do to Done Mar 28, 2018
@jcansdale jcansdale deleted the update/octokit-to-0.29.0 branch Mar 28, 2018
@meaghanlewis meaghanlewis removed this from Done in 2.4.4 Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.