Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Moved changed files tree into its own view. #1492
Conversation
Ported from #1415. Moves the PR details changed files tree into its own view so that it can be shared by the PR reviews view.
e28ef32
to
f72df0c
| // If the target line doesn't have a unique match, search this number of lines above looking for a match. | ||
| public const int MatchLinesAboveTarget = 4; | ||
|
|
||
| readonly IGitHubServiceProvider serviceProvider; |
jcansdale
Mar 16, 2018
Collaborator
It looks like this is no longer being used.
It looks like this is no longer being used.
grokys
Mar 16, 2018
Author
Contributor
It is still being used!
It is still being used!
| @@ -2,47 +2,52 @@ | |||
| xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" | |||
| xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" | |||
| xmlns:d="http://schemas.microsoft.com/expression/blend/2008" | |||
| xmlns:ghfvs="https://github.com/github/VisualStudio" | |||
jcansdale
Mar 16, 2018
Collaborator
Should we be replacing this? Isn't it the new style of XAML reference that was recently merged?
Should we be replacing this? Isn't it the new style of XAML reference that was recently merged?
grokys
Mar 16, 2018
Author
Contributor
Oops, merge/rebase error!
Oops, merge/rebase error!
| } | ||
|
|
||
| [Import] | ||
| ITeamExplorerServiceHolder TeamExplorerServiceHolder { get; set; } | ||
|
|
||
| [Import] | ||
| IVisualStudioBrowser VisualStudioBrowser { get; set; } |
jcansdale
Mar 16, 2018
Collaborator
I'm curious why we're not using an ImportingConstructor for this. Is this something specific to views?
I'm curious why we're not using an ImportingConstructor for this. Is this something specific to views?
grokys
Mar 16, 2018
Author
Contributor
If you don't have a default constructor, the designer can't create an instance. We could have a default constructor as well as the importing constructor, but at the time this was written I guess we decided to do it like this.
If you don't have a default constructor, the designer can't create an instance. We could have a default constructor as well as the importing constructor, but at the time this was written I guess we decided to do it like this.
| xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" | ||
| xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" | ||
| xmlns:d="http://schemas.microsoft.com/expression/blend/2008" | ||
| xmlns:cache="clr-namespace:GitHub.UI.Helpers;assembly=GitHub.UI" |
jcansdale
Mar 16, 2018
Collaborator
Could we use xmlns:ghfvs="https://github.com/github/VisualStudio" for some of these?
Could we use xmlns:ghfvs="https://github.com/github/VisualStudio" for some of these?
grokys
Mar 16, 2018
Author
Contributor
Yep, we could!
Yep, we could!
|
See inline comments. There is also the following CA error:
|
Enable navigation from diff view to editor
|
@jcansdale fixed those issues. Turns out #1407 wasn't ported to this branch, which was why |
|
Looks good LGTM. |
Ported from #1415. Moves the PR details changed files tree into its own view so that it can be shared by the PR review authoring view.
Part of #1491