Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upConsistently name all VS commands #1638
Merged
Conversation
Name all commands using a `GitHub.` prefix. Give commands both a CanonicalName and a LocCanonicalName (for the keyboard shortcuts dialog).
|
Thanks for doing this @jcansdale. It will be great to have these extra commands! |
|
LGTM! I did notice that some commands don't seem to do anything when run from the command window, such as GitHub.Help, though I don't think that's an issue with this PR. |
|
This will also help with #1637 right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jcansdale commentedMay 2, 2018
•
edited
This PR uses a tip shared by @madskristensen to ensure that all commands have a consistent name.
https://twitter.com/jcansdale/status/991013150932729856
https://twitter.com/mkristensen/status/991018416222818306
What this PR does
Previously our commands would appear on the shortcuts search dialog with inconsistent prefixes (some didn't even contain
GitHuband were difficult to find).GitHub.Specify a
CanonicalNamefor all commands (this is used in theCommand Window)Specify a
LocCanonicalNamefor all commands (used inCustomize > Keyboard...dialog)Our commands now appear as follows
Previously they appeared as in the screenshot above + the following:
Reviewers
This PR is deliberately being kept simple. Is there any reason not to do this?😉
I hope having all of these commands consistently named will allow for faster and more stable automation testing. //paging @meaghanlewis
How to test
These commands names are surfaced in a few places
Command Windowif you start typingGitHub.Customize...,Keyboard...and start typingGitHubinShow commands containing.Future PRs
There is a bunch of functionality that is not being exposed as VS commands (e.g. show PR list of sync submodules). We should fix this but in separate PRs.
Fixes #1630