Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigate to editor. #1580

Merged
merged 3 commits into from Apr 10, 2018
Merged

Fix navigate to editor. #1580

merged 3 commits into from Apr 10, 2018

Conversation

@grokys
Copy link
Contributor

grokys commented Apr 4, 2018 •
edited by jcansdale

This code was accidentally removed in fa8aab8

  • Fix navigate from View Changes to editor
  • Fix navigate from View File to editor

Previously the menu option to navigate from the diff view to the file in the solution was missing from the context menu - this adds it back.

Depends on #1578
Part of #1491
Fixes #1580
@grokys
Fix navigate to editor.
Loading status checks…
c917d44 
This code was accidentally removed in fa8aab8
@grokys grokys requested review from sguthals, meaghanlewis and jcansdale Apr 4, 2018
@grokys grokys changed the base branch from master to feature/pr-reviews-master Apr 4, 2018
This was referenced Apr 4, 2018
Closed
Merged
Merged
@jcansdale
Fix navigate from 'View File' to editor
Loading status checks…
9189d6b
@jcansdale
jcansdale approved these changes Apr 4, 2018
View changes
Copy link
Collaborator

jcansdale left a comment

There was a similar issue with navigating from View File to editor. I've pushed a fix. Apart from that, this is good to go! 🎉
@jcansdale
Make GetAbsolutePath use Windows '\' separator
Loading status checks…
a4fe246
@jcansdale
jcansdale approved these changes Apr 4, 2018
View changes
Copy link
Collaborator

jcansdale left a comment

Fixed an issue with the / separator in GetAbsolutePath. I'll keep dogfooding this build.
@meaghanlewis
Copy link
Contributor

meaghanlewis commented Apr 4, 2018

LGTM 👍
@jcansdale jcansdale changed the base branch from feature/pr-reviews-master to feature/pr-reviews Apr 10, 2018
@jcansdale jcansdale changed the base branch from feature/pr-reviews to feature/pr-reviews-master Apr 10, 2018
@jcansdale jcansdale merged commit d74fa01 into feature/pr-reviews-master Apr 10, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jcansdale jcansdale deleted the fixes/navigate-to-editor branch Apr 10, 2018
@meaghanlewis meaghanlewis mentioned this pull request Apr 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcansdale jcansdale

@sguthals sguthals

@meaghanlewis meaghanlewis

Assignees
No one assigned
Labels
verified
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@grokys @meaghanlewis @jcansdale
You can’t perform that action at this time.