Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure that the GitHubPaneViewModel is initalized. #1426
Merged
Conversation
- Renamed `IGitHubToolWindowManager.ShowHomePane` to `ShowGitHubPane` because the latter is what we call it these days - Make `IGitHubToolWindowManager.ShowGitHubPane` async to make sure that `GitHubPaneViewModel.InitializeAsync` has finished before passing back a refrence to the `GitHubPaneViewModel` - Make the methods that call `IGitHubToolWindowManager.ShowGitHubPane` `void async` with logging when they fail
|
When the GitHub pane is shown from VS rather than our own code, kick off an initialization of the view model. This means we can't be sure of the state of the view model's initialization so make subsequent calls to the view model async either wait for an ongoing initialization, or exit if already initialized.
|
@jcansdale could you take another look at this? It's hopefully working now. |
| /// Ensures that the service is initialized. | ||
| /// </summary> | ||
| /// <returns>A task that when completed indicates that the service is initialized.</returns> | ||
| /// <remarks> |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jcansdale
Feb 7, 2018
Collaborator
Hmm, is seems I missed the line with simplying and it isn't showing up for me as an in-line comment. What's going on?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
grokys commentedJan 23, 2018
IGitHubToolWindowManager.ShowHomePanetoShowGitHubPanebecause the latter is what we call it these daysIGitHubToolWindowManager.ShowGitHubPaneasync to make sure thatGitHubPaneViewModel.InitializeAsynchas finished before passing back a refrence to theGitHubPaneViewModelIGitHubToolWindowManager.ShowGitHubPanevoid asyncwith logging when they fail