Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Use Timer in usage tracker. #960
Merged
Conversation
Use Timer instead of DispatcherTimer in usage tracker. Because `TimerTick` does IO, we should be running on a b/g thread.
|
|
||
| namespace GitHub.Services | ||
| { | ||
| public class UsageTracker : IUsageTracker | ||
| public sealed class UsageTracker : IUsageTracker, IDisposable |
jcansdale
Apr 27, 2017
Collaborator
Sealing your disposable classes? I see what you did there. 😉
Sealing your disposable classes? I see what you did there.
grokys
Apr 27, 2017
Author
Contributor
Ha yeah, easier than implementing the disposable pattern and getting it wrong.
Ha yeah, easier than implementing the disposable pattern and getting it wrong.
grokys
Apr 27, 2017
Author
Contributor
Also this class is a singleton, so Dispose won't even be called.
Also this class is a singleton, so Dispose won't even be called.
haacked
Apr 27, 2017
Contributor
LOL! I do this all the time in apps. Less so in libraries. But it's very convenient to just seal them until you need them not to be sealed. 😄
LOL! I do this all the time in apps. Less so in libraries. But it's very convenient to just seal them until you need them not to be sealed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Use Timer instead of DispatcherTimer in usage tracker. Because
TimerTickdoes IO, we should be running on a b/g thread.