Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
InfoPanel Fixes. #1133
Merged
InfoPanel Fixes. #1133
Conversation
The panel won't display a message if we don't bind the property! Fixes #1131
Use a VS brush to make it the correct color.
| var url = e.Parameter.ToString(); | ||
|
|
||
| if (!string.IsNullOrEmpty(url)) | ||
| Browser.OpenUrl(new Uri(url)); |
jcansdale
Aug 16, 2017
Collaborator
Similar to other PR. What is url is malformed?
Similar to other PR. What is url is malformed?
shana
Aug 16, 2017
Collaborator
We set the urls in the info panels, it's not from user input, so they should never be malformed. If they are and throw, we should catch that in testing (we are clicking on every infopanel that we have during testing to make sure nothing regressed, right? 😉 )
We set the urls in the info panels, it's not from user input, so they should never be malformed. If they are and throw, we should catch that in testing (we are clicking on every infopanel that we have during testing to make sure nothing regressed, right?
This was referenced Aug 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
A few
InfoPanelfixes:MarkdownViewer.MarkdowninInfoPanel.xaml- the panel won't display a message if we don't bind the property!VsBrush.InfoBackgroundas the background color, previously it was justBeigeFixes #1131