Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAssets management refactored #2314
Conversation
gorhill
added some commits
Jan 14, 2017
dhowe
referenced this pull request
Jan 17, 2017
Closed
Add update button for adnauseam.txt only #752
gorhill
added some commits
Jan 17, 2017
gorhill
merged commit 3b9fd49
into
master
Jan 18, 2017
1 check passed
gorhill
deleted the
assets
branch
Jan 18, 2017
gorhill
referenced this pull request
Jan 19, 2017
Closed
Purging caches deselects filter lists #1429
This comment has been minimized.
This comment has been minimized.
ghost
commented
Jan 19, 2017
•
|
Sorry for asking this here but:
Any reason for it being that long? A shorter update interval of maybe a few hours could be useful for lists such as Yhonay/antipopads which have a high update frequency. Thanks for this huge update by the way. |
This comment has been minimized.
This comment has been minimized.
|
I just mind the hit on the remote servers. |
This comment has been minimized.
This comment has been minimized.
ghost
commented
Jan 19, 2017
•
|
That makes sense. I just thought whoever uploads the list can decide how much load they want to have on their server by updating the |
This comment has been minimized.
This comment has been minimized.
Does this also apply to |
This comment has been minimized.
This comment has been minimized.
No What I could do is to automatically mark |
gorhill commentedJan 16, 2017
•
edited
This fixes the following issues: #2281, #2037, #1961, #1749, #1429, #1293, #1275, #344.
The purpose of the refactoring was to address many issues arising from the old assets management code:
Expires:directive in Adblock Plus-compatible filter lists, if present. However the minimal interval is set to 2 days.checksums.txtresource hosted on GitHub to find out whether some specific assets have changed: the update logic is now completely time-based.checksums.txtwill be deprecated and will no longer be updated. Eventually in some future it will be removed from the repository.assets/assets.json, which is itself an update-able asset from uBO's point of view.assetsBootstrapLocationcan be used by derivative works of uBO to provide a different set of stock assets, including which filter lists should be enabled by default at install time. There is also a corresponding settingassetsBootstrapLocationwhich can be used by admins to tell uBO what are the stock assets and which filter lists are enabled by default at install time.assets/ublock/filter-lists.jsonwill be deprecated and will no longer be updated. Eventually in some future it will be removed from the repository.