Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLogger timestamps are incorrect when system time zone is not on hour boundary #2301
Comments
|
Consider making the PR yourself. |
|
Thanks for investigating the source of the issue. |
|
Confirmed fixed in 1.10.7rc0. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Read first: https://github.com/gorhill/uBlock/blob/master/CONTRIBUTING.md
Describe the issue
Entry timestamps in the logger are incorrect when the system time zone's UTC offset is not on an hour boundary (e.g. Newfoundland Time Zone at -03:30 UTC, Nepal Standard Time at +05:45 UTC).
One or more specific URLs where the issue occurs
N/A
Screenshot in which the issue can be seen
N/A
Steps for anyone to reproduce the issue
Fix seems trivial: using
getUTCMinutes()rather thangetMinutes()in line 546 of /src/js/logger-ui.js gives the correct timestamp, since the offset is already applied viasetTime().Your settings
[If you fail to provide this info, I will mark the issue as invalid. Lists all settings which differs from default settings]
Your filter lists
N/A
Your custom filters (if any)