Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firefox] Move script tag filtering data into content process side #2014

Closed
gorhill opened this issue Sep 21, 2016 · 2 comments
Closed

[Firefox] Move script tag filtering data into content process side #2014

gorhill opened this issue Sep 21, 2016 · 2 comments

Comments

@gorhill
Copy link
Owner

@gorhill gorhill commented Sep 21, 2016

This will allow uBO's content-side code to no longer need to synchronously message uBO's core-side code to fetch the script tag filtering data. There is currently only 36 such filters (which works only on Firefox currently), so I do not see size being an issue to keep a copy of these filters content-side.

a

Related issue: #756.

@gorhill
Copy link
Owner Author

@gorhill gorhill commented Sep 23, 2016

@gorhill
Copy link
Owner Author

@gorhill gorhill commented Sep 23, 2016

Code change is to query for script tag filters if and only if there are script tag filters for the current site. For doing so, the content script module only needs a dictionary of hostnames for which there are script tag filters. As a result, for most visited web sites, there won't be a synchronous message. Following code change, using the same benchmarked page:

a

@gorhill gorhill closed this in 95ec573 Sep 24, 2016
gorhill added a commit that referenced this issue Sep 24, 2016
gorhill added a commit that referenced this issue Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.