Skip to content

/ pygit2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce libgit2 options #350

Merged
merged 2 commits into from Mar 23, 2014
Merged

Introduce libgit2 options #350

merged 2 commits into from Mar 23, 2014

Conversation

@carlosmn
Copy link
Member

carlosmn commented Mar 23, 2014

Allow setting and getting the mwindow size and search paths.

This is a first approximation, mapping libgit2's API one-to-one, though I can imagine we might like to have some global where we can set and get in a less annoying way, maybe a global pygit2.settings class with setters and getters than we can use, like

mmap_size = pygit2.settings.mmap_size

pygit2.settings.search_path[pygit2.GIT_CONFIG_LEVEL_GLOBAL] = '/var/lib/nobody'
carlosmn added 2 commits Mar 23, 2014
@carlosmn
Introduce libgit2 options
Loading status checks…
ab44196 
Allow setting and getting the mwindow size and search paths.
@carlosmn
Create proxy object for libgit2 options
Loading status checks…
48ff3a8 
pygit2.settings proxies though the lower-level varargs option() via
getters and setters which provide a more natural abstraction.
@carlosmn
Copy link
Member Author

carlosmn commented Mar 23, 2014

Ok, I've added a pygit2.settings object to proxy the calls to something that makes some sense from python.
@jdavid jdavid merged commit 48ff3a8 into libgit2:master Mar 23, 2014
1 check failed
1 check failed
default The Travis CI build failed
Details
@carlosmn carlosmn deleted the carlosmn:options branch Mar 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@carlosmn @jdavid
You can’t perform that action at this time.