Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement all of the options for `init_repository` from libgit. #347
Conversation
… provided by libgit for init_repository.
This comment has been minimized.
This comment has been minimized.
jdavid
commented on src/pygit2.c in 9e6057d
Feb 21, 2014
|
Variables must be declared at the beginning. We have already broken support for VisualStudio several times this way. |
This comment has been minimized.
This comment has been minimized.
jdavid
commented on src/pygit2.c in 9e6057d
Feb 21, 2014
|
Please use |
|
Is this acceptable? |
|
I made just one comment regarding in-line variable declarations, but there more. Please go through your commit and fix all of them. Thanks. |
|
done using cffi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
atheriel commentedFeb 21, 2014
This patch should fully implement all of the options currently provided by git_repository_init_options for initializing repositories.
Much of the C code is drawn from libgit's
init.cexample.I have made one implementation change: setting the working tree will work like git-init(1) instead of the way it works in libgit, in that it uses an absolute path as opposed to a path relative to the repository. This means that
will result in the following directory structure
as opposed to the default behaviour, which creates
A full use of the options might look like the following at the moment:
Let me know if there's anything I else I can do.
Aaron Jacobs
atheriel@gmail.com