Skip to content

/ pygit2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrap_remote. #332

Merged
merged 2 commits into from Jan 29, 2014
Merged

Add wrap_remote. #332

merged 2 commits into from Jan 29, 2014

Conversation

@xtao
Copy link
Contributor

xtao commented Jan 29, 2014

Please review, thanks.
@xtao
Add wrap remote.
Loading status checks…
5b4b7f3
@xtao xtao mentioned this pull request Jan 29, 2014
Closed
@jdavid

This comment has been minimized.

Sign in to view
Copy link

jdavid commented on src/repository.c in 5b4b7f3 Jan 29, 2014

Here you don't check whether wrap_remote returns NULL
@jdavid
Copy link
Member

jdavid commented Jan 29, 2014

Now Remote_init can be removed. And then Remote_set_callbacks can be merged into wrap_remote.
@xtao
Drop Remote_init.
Loading status checks…
f79ae6b
@xtao
Copy link
Contributor Author

xtao commented Jan 29, 2014

@jdavid Fixed. 🍺
@jdavid jdavid merged commit f79ae6b into libgit2:master Jan 29, 2014
1 check passed
1 check passed
default The Travis CI build passed
Details
@IfeanyiEkperi
Copy link

IfeanyiEkperi commented Jan 29, 2014

plaese what is all this about
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@xtao @jdavid @IfeanyiEkperi
You can’t perform that action at this time.