Project

General

Profile

Actions

Bug #73550

closed

mds: update older versioned sr_t struct(s) to incorporate snapshot visibility flag

Added by Dhairya Parmar 5 months ago. Updated 26 days ago.

Status:
Resolved
Priority:
Normal
Category:
Correctness/Safety
Target version:
% Done:

0%

Source:
Q/A
Backport:
tentacle
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
MDS
Labels (FS):
snapshots
Pull request ID:
Tags (freeform):
backport_processed
Fixed In:
v20.3.0-4464-gba6e1ce935
Released In:
Upkeep Timestamp:
2026-02-24T13:12:30+00:00

Description

If there is cluster upgrade, the older sr_t structs' flags would not have the SNAPSHOT_VISIBILITY flag bit set which means the existing subvolumes would report 0 instead of 1 for the vxattr ceph.dir.subvolume.snaps.visible which although doesn't lead to any actual denial of access to subvolume snapshots since the client config to respect snapshot visibility is set to false as default but might come as a surprise to any cluster operator to automatically get EPERMS when they toggle the client config to true. This isn't that big of a pain since one can definitely run ceph fs subvolume snapshot_visibility set command on the existing subvolume(s) post upgrade but a proper solution would be to change the in-memory flags while decoding the sr_t members.


Related issues 2 (0 open2 closed)

Related to CephFS - Bug #71740: mgr/volumes: toggle snapdir visibility for subvolume based pathsResolvedDhairya Parmar

Actions
Copied to CephFS - Backport #74487: tentacle: mds: update older versioned sr_t struct(s) to incorporate snapshot visibility flagRejectedDhairya ParmarActions
Actions #1

Updated by Dhairya Parmar 5 months ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 65960
Actions #2

Updated by Venky Shankar 4 months ago

  • Related to Bug #71740: mgr/volumes: toggle snapdir visibility for subvolume based paths added
Actions #3

Updated by Venky Shankar 4 months ago

  • Status changed from Fix Under Review to Resolved
  • Target version set to v21.0.0
Actions #4

Updated by Upkeep Bot 4 months ago

  • Merge Commit set to ba6e1ce93503dddfefc5360963726f0d0d3204f7
  • Fixed In set to v20.3.0-4464-gba6e1ce935
  • Upkeep Timestamp set to 2025-12-05T10:40:05+00:00
Actions #5

Updated by Dhairya Parmar about 2 months ago

  • Backport set to tentacle
Actions #6

Updated by Dhairya Parmar about 2 months ago

  • Status changed from Resolved to Pending Backport
Actions #7

Updated by Dhairya Parmar about 2 months ago

  • Copied to Backport #74487: tentacle: mds: update older versioned sr_t struct(s) to incorporate snapshot visibility flag added
Actions #8

Updated by Dhairya Parmar about 2 months ago

  • Tags (freeform) set to backport_processed
Actions #9

Updated by Upkeep Bot 26 days ago

  • Status changed from Pending Backport to Resolved
  • Upkeep Timestamp changed from 2025-12-05T10:40:05+00:00 to 2026-02-24T13:12:30+00:00
Actions

Also available in: Atom PDF