Project

General

Profile

Actions
Copy link

Tasks #73416

closed

Tasks #63293: Implement fscrypt in libcephfs and cephfs-fuse

AsyncReadAndWriteMultiClient fails

Added by Christopher Hoffman 5 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Christopher Hoffman
Category:
-
Target version:
-
% Done:

0%

Reviewed:
Affected Versions:
Component(FS):
Labels (FS):
Pull request ID:
Tags (freeform):
Merge Commit:
Fixed In:
Released In:
Upkeep Timestamp:

Description

https://pulpito.ceph.com/choffman-2025-10-07_20:47:23-fs-wip-choffman-fscrypt-distro-default-smithi/8539497/

2025-10-07T22:18:11.053 INFO:tasks.workunit.client.0.smithi112.stdout:[ RUN      ] LibCephFS.AsyncReadAndWriteMultiClient
2025-10-07T22:18:11.111 INFO:tasks.workunit.client.0.smithi112.stdout:: waiting for write to finish
2025-10-07T22:18:11.118 INFO:tasks.workunit.client.0.smithi112.stdout:written=131072
2025-10-07T22:18:11.118 INFO:tasks.workunit.client.0.smithi112.stdout:: write finished
2025-10-07T22:18:11.118 INFO:tasks.workunit.client.0.smithi112.stdout:read=0
2025-10-07T22:18:11.118 INFO:tasks.workunit.client.0.smithi112.stdout:: waiting for read to finish
2025-10-07T22:18:11.118 INFO:tasks.workunit.client.0.smithi112.stdout:: read finished
2025-10-07T22:18:11.119 INFO:tasks.workunit.client.0.smithi112.stdout:./src/test/libcephfs/test.cc:4384: Failure
2025-10-07T22:18:11.119 INFO:tasks.workunit.client.0.smithi112.stdout:Expected equality of these values:
2025-10-07T22:18:11.119 INFO:tasks.workunit.client.0.smithi112.stdout:  io_info.result
2025-10-07T22:18:11.119 INFO:tasks.workunit.client.0.smithi112.stdout:    Which is: 0
2025-10-07T22:18:11.119 INFO:tasks.workunit.client.0.smithi112.stdout:  sizeof(buf)
2025-10-07T22:18:11.119 INFO:tasks.workunit.client.0.smithi112.stdout:    Which is: 131072
2025-10-07T22:18:11.119 INFO:tasks.workunit.client.0.smithi112.stdout:
2025-10-07T22:18:11.119 INFO:tasks.workunit.client.0.smithi112.stdout:[  FAILED  ] LibCephFS.AsyncReadAndWriteMultiClient (64 ms)
Actions
Copy link
 #1

Updated by Christopher Hoffman 5 months ago

  • Status changed from New to Resolved
Author: Christopher Hoffman <choffman@redhat.com>
Date:   Tue Oct 28 12:46:34 2025 +0000

    client: Do not check file size during trim read

    The commit 154b86743b52 reverted part of the fix seen in 2b74598afc.
    This commit will reapply any missing changes of the fix.

    Fixes: https://tracker.ceph.com/issues/73416
    Signed-off-by: Christopher Hoffman <choffman@redhat.com>

diff --git a/src/client/Client.cc b/src/client/Client.cc
index 74429395765..16ba9414859 100644
--- a/src/client/Client.cc
+++ b/src/client/Client.cc
@@ -11679,7 +11679,7 @@ retry:
     // C_Read_Sync_NonBlocking::finish().

     // trim read based on file size?
-    if (std::cmp_greater_equal(offset, in->effective_size()) || (size == 0)) {
+    if (size == 0) {
       // zero byte read requested -- therefore just release managed
       // pointers and complete the C_Read_Finisher immediately with 0 bytes
       Context *iof = iofinish.release();
Actions
Copy link

Also available in: Atom PDF