Ceph » CephFS

Following elif clause is where readability can be improved -

        except VolumeException as ve:
            if ve.errno == -errno.EAGAIN and not force:
                ve = VolumeException(ve.errno, ve.error_str + " (use --force to override)")
                ret = self.volume_exception_to_retval(ve)
            elif not (ve.errno == -errno.ENOENT and force):
                ret = self.volume_exception_to_retval(ve)
        return ret

If (ve.errno -errno.ENOENT and force) is True, ret remains initiated to its default value (which is 0) and thus zero is returned. Neither we inform user why zero is retuned in this case and checking for boolean value of not (ve.errno -errno.ENOENT and force) makes code a bit complicated.