Actions
Enhancement #70875
openErrorator: address TODO
Status:
New
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
% Done:
0%
Source:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Tags (freeform):
Merge Commit:
Fixed In:
Released In:
Upkeep Timestamp:
Description
1)
// TODO: we don't really need to `make_exception_ptr` each time. It still
// allocates memory underneath while can be replaced with single instance
// per type created on start-up.
2)
_future finally(FuncT &&func) {
return this->then_wrapped(
[func = std::forward<FuncT>(func)](auto &&result) mutable noexcept {
if constexpr (seastar::InvokeReturnsAnyFuture<FuncT>) {
return ::seastar::futurize_invoke(std::forward<FuncT>(func)).then_wrapped(
[result = std::move(result)](auto&& f_res) mutable {
// TODO: f_res.failed()
(void)f_res.discard_result();
return std::move(result);
});
} else {
try {
func();
} catch (...) {
// TODO: rethrow
}
return std::move(result);
}
});
}
3)
// TODO: add missing explanation
4) Removed in https://github.com/ceph/ceph/pull/62699 - this TODO was added as an usage example before we had any
// assert_all{ "TODO" };
Actions