Project

General

Profile

Actions
Copy link

Feature #69990

closed

Introduce and implement FuturizedStore::Shard::omap_iterate()

Added by Yingxin Cheng about 1 year ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
chunmei liu
Category:
Seastore
Target version:
-
% Done:

0%

Source:
Backport:
Reviewed:
Affected Versions:
Pull request ID:
62530
Tags (freeform):
Merge Commit:
853c60925ea0f236700881c45b8b5da88887d521
Fixed In:
v20.3.0-1640-g853c60925e
Released In:
Upkeep Timestamp:
2025-08-12T18:23:44+00:00

Description

Refer to ObjectStore::omap_iterate(), Crimson needs a similar interface from FuturizedStore to iterate the omap on demand, instead of relying solely on omap_get_values().

Related issues 1 (0 open — 1 closed)

Related to crimson - Bug #69612: Seastore: rbd_cls_tests/perf-fio_4M_rand_rw osd.x has slow opsResolvedchunmei liu

Actions
Actions
Copy link
 #1

Updated by Yingxin Cheng about 1 year ago

  • Related to Bug #69612: Seastore: rbd_cls_tests/perf-fio_4M_rand_rw osd.x has slow ops added
Actions
Copy link
 #2

Updated by Matan Breizman about 1 year ago

Note: Classical "drop the OmapIterator in favor of omap_iterate" https://github.com/ceph/ceph/pull/60890

Actions
Copy link
 #3

Updated by Matan Breizman about 1 year ago

  • Assignee set to chunmei liu
Actions
Copy link
 #4

Updated by Yingxin Cheng about 1 year ago

Hey, it should be good to base on the cleanup https://github.com/ceph/ceph/pull/62079 which tries to simplify the omap code in seastore.cc

Actions
Copy link
 #5

Updated by Matan Breizman 11 months ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 62530
Actions
Copy link
 #6

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to 853c60925ea0f236700881c45b8b5da88887d521
  • Fixed In set to v20.3.0-1640-g853c60925e
  • Upkeep Timestamp set to 2025-07-15T14:55:43+00:00
Actions
Copy link
 #7

Updated by Matan Breizman 8 months ago

https://github.com/ceph/ceph/pull/62530 was merged, leaving the tracker open for follow-up tracking: https://github.com/ceph/ceph/pull/62530#issuecomment-3071792601

Crimson-has-followup:
* Drop duplicated `OMapManager::omap_list()`: https://github.com/ceph/ceph/pull/62530#discussion_r2168305392
* Drop the unnecessary `omap_list_config_t` from `OMapManager::omap_rm_key_range()`

Actions
Copy link
 #8

Updated by Upkeep Bot 7 months ago

  • Status changed from Fix Under Review to Resolved
  • Upkeep Timestamp changed from 2025-07-15T14:55:43+00:00 to 2025-08-12T18:23:44+00:00
Actions
Copy link

Also available in: Atom PDF