Project

General

Profile

Actions

Bug #69669

closed

cephfs-top: exception when terminal size greater than PAD_WIDTH

Added by Jos Collin about 1 year ago. Updated 5 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Administration/Usability
Target version:
% Done:

0%

Source:
Community (dev)
Backport:
reef,squid
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Tags (freeform):
backport_processed
Fixed In:
v19.3.0-7521-gc6fbca3d87
Released In:
v20.2.0~1146
Upkeep Timestamp:
2025-11-01T01:27:21+00:00

Description

cephfs-top shows "exception: curses function returned NULL", when cephfs-top starts in a smaller window (pad_width <= 300) and the user resize the window width > 300 and navigates to the other displays.

We have fixed a similar exception during init: https://github.com/ceph/ceph/pull/59566/commits/a59f007695dd8f4e121613709f4de520eda55ab9. But that's not enough.
The problem is we are using a smaller pad (width = 300), created at init. Then we resize the terminal and try to create new subwindows in the pad, eachtime we navigate. This is not possible and cephfs-top crashes.

The solution is,
We need to fix this by creating a newpad everytime we create a new display, so that the newly created subwindows could accommodate or the subwindow size should be calculated accordingly to create a smaller display to stay with in the pad. I would go with the former, as would create a better display.


Related issues 2 (0 open2 closed)

Copied to CephFS - Backport #69926: reef: cephfs-top: exception when terminal size greater than PAD_WIDTHResolvedJos CollinActions
Copied to CephFS - Backport #69927: squid: cephfs-top: exception when terminal size greater than PAD_WIDTHResolvedJos CollinActions
Actions #1

Updated by Jos Collin about 1 year ago

  • Status changed from New to In Progress
  • Assignee set to Jos Collin
  • Pull request ID set to 61621
Actions #2

Updated by Jos Collin about 1 year ago

  • Status changed from In Progress to Fix Under Review
Actions #3

Updated by Jos Collin about 1 year ago

  • Description updated (diff)
Actions #4

Updated by Venky Shankar about 1 year ago

  • Project changed from Ceph to CephFS
  • Category set to Administration/Usability
  • Status changed from Fix Under Review to Pending Backport
  • Target version set to v20.0.0
  • Backport set to reef,squid
Actions #5

Updated by Upkeep Bot about 1 year ago

  • Copied to Backport #69926: reef: cephfs-top: exception when terminal size greater than PAD_WIDTH added
Actions #6

Updated by Upkeep Bot about 1 year ago

  • Copied to Backport #69927: squid: cephfs-top: exception when terminal size greater than PAD_WIDTH added
Actions #7

Updated by Upkeep Bot about 1 year ago

  • Tags (freeform) set to backport_processed
Actions #8

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to c6fbca3d87eb97156402f3ba059d5428229a7a9b
  • Fixed In set to v19.3.0-7521-gc6fbca3d87e
  • Upkeep Timestamp set to 2025-07-08T18:12:14+00:00
Actions #9

Updated by Jos Collin 8 months ago

  • Status changed from Pending Backport to Resolved
Actions #10

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v19.3.0-7521-gc6fbca3d87e to v19.3.0-7521-gc6fbca3d87
  • Upkeep Timestamp changed from 2025-07-08T18:12:14+00:00 to 2025-07-14T16:46:01+00:00
Actions #11

Updated by Upkeep Bot 5 months ago

  • Released In set to v20.2.0~1146
  • Upkeep Timestamp changed from 2025-07-14T16:46:01+00:00 to 2025-11-01T01:27:21+00:00
Actions

Also available in: Atom PDF