Project

General

Profile

Actions
Copy link

Bug #69240

closed

os/bluestore/BlueStore.cc: failure to build with -Werror: comparison of integer expressions of different signedness

Added by John Mulligan over 1 year ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Adam Emerson
Target version:
-
% Done:

0%

Source:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
61326
Tags (freeform):
Merge Commit:
b0ef526071112487e167395b11c0816a07cc0ef5
Fixed In:
v19.3.0-7493-gb0ef526071
Released In:
v20.2.0~1152
Upkeep Timestamp:
2025-11-01T01:15:08+00:00

Description

I hit this as an error while trying to build on ubuntu 24.04 in container. This envioronment has set -Werror by default. I can force -Werror off temporarily by hacking the build script (src/script/run-make.sh) but this isn't a good long term solution.

[23/546] Building CXX object src/os/CMakeFiles/os.dir/bluestore/BlueStore.cc.o
FAILED: src/os/CMakeFiles/os.dir/bluestore/BlueStore.cc.o 
/usr/bin/ccache /usr/bin/g++ -DBOOST_ASIO_DISABLE_THREAD_KEYWORD_EXTENSION -DBOOST_ASIO_HAS_IO_URING -DBOOST_ASIO_NO_TS_EXECUTORS -DHAVE_CONFIG_H -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D_REENTRANT -D_THREAD_SAFE -D__CEPH__ -D__STDC_FORMAT_MACROS -D__linux__ -I/ceph/build.u24x/src/include -I/ceph/src -isystem /ceph/build.u24x/boost/include -isystem /ceph/build.u24x/include -isystem /ceph/src/xxHash -isystem /ceph/src/fmt/include -isystem /ceph/src/rocksdb/include -isystem /ceph/build.u24x/src/liburing/src/include -isystem /usr/include/fuse -Og -Werror -std=c++20 -fPIC -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-free -Wall -fno-strict-aliasing -fsigned-char -Wtype-limits -Wignored-qualifiers -Wpointer-arith -Werror=format-security -Winit-self -Wno-unknown-pragmas -Wnon-virtual-dtor -Wno-ignored-qualifiers -ftemplate-depth-1024 -Wpessimizing-move -Wredundant-move -Wstrict-null-sentinel -Woverloaded-virtual -DCEPH_DEBUG_MUTEX -fstack-protector-strong -D_GLIBCXX_ASSERTIONS -fdiagnostics-color=auto -MD -MT src/os/CMakeFiles/os.dir/bluestore/BlueStore.cc.o -MF src/os/CMakeFiles/os.dir/bluestore/BlueStore.cc.o.d -o src/os/CMakeFiles/os.dir/bluestore/BlueStore.cc.o -c /ceph/src/os/bluestore/BlueStore.cc
/ceph/src/os/bluestore/BlueStore.cc: In member function 'bool BlueStore::BlueStoreThrottle::try_start_transaction(KeyValueDB&, BlueStore::TransContext&, ceph::mono_clock::time_point)':
/ceph/src/os/bluestore/BlueStore.cc:18657:26: error: comparison of integer expressions of different signedness: 'long unsigned int' and 'int64_t' {aka 'long int'} [-Werror=sign-compare]
18657 |     if (cost0 + txc.cost > bytes_observed_max) {
      |         ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
Actions
Copy link
 #1

Updated by Igor Fedotov over 1 year ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 60986
Actions
Copy link
 #2

Updated by Joseph Mundackal about 1 year ago

  • Assignee set to Adam Emerson

To Adam who has an open PR

Actions
Copy link
 #3

Updated by Adam Emerson about 1 year ago

  • Status changed from Fix Under Review to In Progress

I'll split this out, we prefer to have bug fixes be small PRs when possible for backport reasons.

Actions
Copy link
 #4

Updated by Adam Emerson about 1 year ago

  • Pull request ID changed from 60986 to 61326
Actions
Copy link
 #5

Updated by Adam Emerson about 1 year ago

  • Status changed from In Progress to Fix Under Review
Actions
Copy link
 #6

Updated by Igor Fedotov about 1 year ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link
 #7

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to b0ef526071112487e167395b11c0816a07cc0ef5
  • Fixed In set to v19.3.0-7493-gb0ef5260711
  • Upkeep Timestamp set to 2025-07-10T04:45:19+00:00
Actions
Copy link
 #8

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v19.3.0-7493-gb0ef5260711 to v19.3.0-7493-gb0ef526071
  • Upkeep Timestamp changed from 2025-07-10T04:45:19+00:00 to 2025-07-14T19:38:02+00:00
Actions
Copy link
 #9

Updated by Upkeep Bot 5 months ago

  • Released In set to v20.2.0~1152
  • Upkeep Timestamp changed from 2025-07-14T19:38:02+00:00 to 2025-11-01T01:15:08+00:00
Actions
Copy link

Also available in: Atom PDF