Project

General

Profile

Actions

Bug #68998

closed

interrupted flattens resulting in corrupted rbd images

Added by Xuehan Xu over 1 year ago. Updated 5 months ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Target version:
-
% Done:

0%

Source:
Backport:
reef,squid
Regression:
Yes
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Tags (freeform):
backport_processed
Fixed In:
v19.3.0-6584-g30103a03b7
Released In:
v20.2.0~1448
Upkeep Timestamp:
2025-11-01T01:30:02+00:00

Description

A child rbd image cloned from a parent has a high probability to contain corrupt data if a flatten on it is interrupted and restarted later.

we think that this is because object maps of rbd images are updated before the actual object writes happen when creating new objects of images. This might be a problem for flattens. If a flatten is interrupted with object maps updated and the objects not actually fully modified, those objects won't be copied up in later flattens, which leads to corrupted data.


Related issues 3 (0 open3 closed)

Related to rbd - Feature #23445: Flatten operation should use object mapResolvedMykola Golub03/22/2018

Actions
Copied to rbd - Backport #69327: squid: interrupted flattens resulting in corrupted rbd imagesResolvedIlya DryomovActions
Copied to rbd - Backport #69328: reef: interrupted flattens resulting in corrupted rbd imagesResolvedIlya DryomovActions
Actions #1

Updated by Ilya Dryomov over 1 year ago

  • Status changed from New to In Progress
  • Assignee set to Ilya Dryomov
  • Priority changed from Normal to Urgent
  • Backport set to reef,squid
  • Regression changed from No to Yes
Actions #2

Updated by Ilya Dryomov over 1 year ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 61129
Actions #3

Updated by Ilya Dryomov over 1 year ago

  • Related to Feature #23445: Flatten operation should use object map added
Actions #4

Updated by Ilya Dryomov over 1 year ago

Xuehan Xu wrote:

This might be a problem for flattens. If a flatten is interrupted with object maps updated and the objects not actually fully modified, those objects won't be copied up in later flattens, which leads to corrupted data.

Noting that this issue extends beyond an interrupted flatten. If a client running on the clone crashes at the wrong moment, the object map would be left with the same kind of inconsistency. If it's not corrected by that client restarting and writing to the same area as part of filesystem or application level recovery or just by chance in the future, "rbd flatten" would similarly skip the copyup even when running to completion on the first attempt, without ever being interrupted.

Actions #5

Updated by Ilya Dryomov over 1 year ago

  • Status changed from Fix Under Review to Pending Backport
Actions #6

Updated by Upkeep Bot over 1 year ago

  • Copied to Backport #69327: squid: interrupted flattens resulting in corrupted rbd images added
Actions #7

Updated by Upkeep Bot over 1 year ago

  • Copied to Backport #69328: reef: interrupted flattens resulting in corrupted rbd images added
Actions #8

Updated by Upkeep Bot over 1 year ago

  • Tags (freeform) set to backport_processed
Actions #9

Updated by Upkeep Bot about 1 year ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions #10

Updated by Upkeep Bot 9 months ago

  • Merge Commit set to 30103a03b707efd0e39e458d7322e4aa9c0094ec
  • Fixed In set to v19.3.0-6584-g30103a03b70
  • Upkeep Timestamp set to 2025-07-10T06:13:41+00:00
Actions #11

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v19.3.0-6584-g30103a03b70 to v19.3.0-6584-g30103a03b7
  • Upkeep Timestamp changed from 2025-07-10T06:13:41+00:00 to 2025-07-14T19:38:25+00:00
Actions #12

Updated by Upkeep Bot 5 months ago

  • Released In set to v20.2.0~1448
  • Upkeep Timestamp changed from 2025-07-14T19:38:25+00:00 to 2025-11-01T01:30:02+00:00
Actions

Also available in: Atom PDF