Project

General

Profile

Actions
Copy link

Bug #68102

closed

rgw: "radosgw-admin topic list" may contain duplicated data and redundant nesting

Added by Alex Kershaw over 1 year ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Ali Masarwa
Target version:
-
% Done:

0%

Source:
Community (user)
Backport:
squid
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
Ceph - v19.1.1
ceph-qa-suite:
Pull request ID:
60045
Tags (freeform):
backport_processed
Merge Commit:
66bf56ec50d0e1688ffc2601a12a365d94466b90
Fixed In:
v19.3.0-5656-g66bf56ec50
Released In:
v20.2.0~1758
Upkeep Timestamp:
2025-11-01T01:30:38+00:00
Tags:
notifications

Description

Running Squid 19.1.1, creating topics and listing topics can result in strange behavior when notification_v2 is disabled. The below is from a system where I:
- had notification_v2 enabled
- deleted all the topics and notifications
- disabled notification_v2
- recreated the topics and notifications

Notice how the same two topics "noirtopic" and "starlighttopic" are repeated multiple times.

[qs-admin@noir-sc-1 ~]$ rga topic list
{
    "topics": [
        {
            "topics": [
                {
                    "owner": "theboys",
                    "name": "noirtopic",
                    "dest": {
                        "push_endpoint": "https://10.235.22.26:8104/s3mgr",
                        "push_endpoint_args": "verify-ssl=false",
                        "push_endpoint_topic": "noirtopic",
                        "stored_secret": false,
                        "persistent": true,
                        "persistent_queue": ":noirtopic",
                        "time_to_live": "None",
                        "max_retries": "None",
                        "retry_sleep_duration": "10" 
                    },
                    "arn": "arn:aws:sns:geored_zg::noirtopic",
                    "opaqueData": "",
                    "policy": "" 
                },
                {
                    "owner": "theboys",
                    "name": "starlighttopic",
                    "dest": {
                        "push_endpoint": "https://10.235.22.28:8104/s3mgr",
                        "push_endpoint_args": "rgwx-uid=theboys&rgwx-zonegroup=c6f83c55-d7fe-4132-8e2b-c346a95f7147&verify-ssl=false",
                        "push_endpoint_topic": "starlighttopic",
                        "stored_secret": false,
                        "persistent": true,
                        "persistent_queue": ":starlighttopic",
                        "time_to_live": "None",
                        "max_retries": "None",
                        "retry_sleep_duration": "10" 
                    },
                    "arn": "arn:aws:sns:geored_zg::starlighttopic",
                    "opaqueData": "",
                    "policy": "" 
                }
            ]
        },
        {
            "topics": [
                {
                    "owner": "theboys",
                    "name": "noirtopic",
                    "dest": {
                        "push_endpoint": "https://10.235.22.26:8104/s3mgr",
                        "push_endpoint_args": "verify-ssl=false",
                        "push_endpoint_topic": "noirtopic",
                        "stored_secret": false,
                        "persistent": true,
                        "persistent_queue": ":noirtopic",
                        "time_to_live": "None",
                        "max_retries": "None",
                        "retry_sleep_duration": "10" 
                    },
                    "arn": "arn:aws:sns:geored_zg::noirtopic",
                    "opaqueData": "",
                    "policy": "" 
                },
                {
                    "owner": "theboys",
                    "name": "starlighttopic",
                    "dest": {
                        "push_endpoint": "https://10.235.22.28:8104/s3mgr",
                        "push_endpoint_args": "rgwx-uid=theboys&rgwx-zonegroup=c6f83c55-d7fe-4132-8e2b-c346a95f7147&verify-ssl=false",
                        "push_endpoint_topic": "starlighttopic",
                        "stored_secret": false,
                        "persistent": true,
                        "persistent_queue": ":starlighttopic",
                        "time_to_live": "None",
                        "max_retries": "None",
                        "retry_sleep_duration": "10" 
                    },
                    "arn": "arn:aws:sns:geored_zg::starlighttopic",
                    "opaqueData": "",
                    "policy": "" 
                }
            ]
        },
        {
            "topics": [
                {
                    "owner": "theboys",
                    "name": "noirtopic",
                    "dest": {
                        "push_endpoint": "https://10.235.22.26:8104/s3mgr",
                        "push_endpoint_args": "verify-ssl=false",
                        "push_endpoint_topic": "noirtopic",
                        "stored_secret": false,
                        "persistent": true,
                        "persistent_queue": ":noirtopic",
                        "time_to_live": "None",
                        "max_retries": "None",
                        "retry_sleep_duration": "10" 
                    },
                    "arn": "arn:aws:sns:geored_zg::noirtopic",
                    "opaqueData": "",
                    "policy": "" 
                },
                {
                    "owner": "theboys",
                    "name": "starlighttopic",
                    "dest": {
                        "push_endpoint": "https://10.235.22.28:8104/s3mgr",
                        "push_endpoint_args": "rgwx-uid=theboys&rgwx-zonegroup=c6f83c55-d7fe-4132-8e2b-c346a95f7147&verify-ssl=false",
                        "push_endpoint_topic": "starlighttopic",
                        "stored_secret": false,
                        "persistent": true,
                        "persistent_queue": ":starlighttopic",
                        "time_to_live": "None",
                        "max_retries": "None",
                        "retry_sleep_duration": "10" 
                    },
                    "arn": "arn:aws:sns:geored_zg::starlighttopic",
                    "opaqueData": "",
                    "policy": "" 
                }
            ]
        },
        {
            "topics": [
                {
                    "owner": "theboys",
                    "name": "noirtopic",
                    "dest": {
                        "push_endpoint": "https://10.235.22.26:8104/s3mgr",
                        "push_endpoint_args": "verify-ssl=false",
                        "push_endpoint_topic": "noirtopic",
                        "stored_secret": false,
                        "persistent": true,
                        "persistent_queue": ":noirtopic",
                        "time_to_live": "None",
                        "max_retries": "None",
                        "retry_sleep_duration": "10" 
                    },
                    "arn": "arn:aws:sns:geored_zg::noirtopic",
                    "opaqueData": "",
                    "policy": "" 
                },
                {
                    "owner": "theboys",
                    "name": "starlighttopic",
                    "dest": {
                        "push_endpoint": "https://10.235.22.28:8104/s3mgr",
                        "push_endpoint_args": "rgwx-uid=theboys&rgwx-zonegroup=c6f83c55-d7fe-4132-8e2b-c346a95f7147&verify-ssl=false",
                        "push_endpoint_topic": "starlighttopic",
                        "stored_secret": false,
                        "persistent": true,
                        "persistent_queue": ":starlighttopic",
                        "time_to_live": "None",
                        "max_retries": "None",
                        "retry_sleep_duration": "10" 
                    },
                    "arn": "arn:aws:sns:geored_zg::starlighttopic",
                    "opaqueData": "",
                    "policy": "" 
                }
            ]
        }
    ]
}

I also attempted to reproduce the behavior without ever creating any notification_v2 topics/notifications.
- Fresh install at 19.1.1.
- Immediately disable notification_v2.
- Create a single topic/notification.

And I got the below when listing:

[qs-admin@zeratul-sc-1 ~]$ rga topic list
{
    "topics": [
        {
            "topics": [
                {
                    "owner": "zone.user",
                    "name": "ahk2",
                    "dest": {
                        "push_endpoint": "https://1.2.3.4:8104/s3mgr?token=mytoken",
                        "push_endpoint_args": "verify-ssl=false",
                        "push_endpoint_topic": "ahk2",
                        "stored_secret": false,
                        "persistent": true,
                        "persistent_queue": ":ahk2",
                        "time_to_live": "None",
                        "max_retries": "None",
                        "retry_sleep_duration": "10" 
                    },
                    "arn": "arn:aws:sns:geored_zg::ahk2",
                    "opaqueData": "",
                    "policy": "" 
                }
            ]
        }
    ]
}

Notice the duplication and double nesting of "topics".

Related issues 1 (0 open — 1 closed)

Copied to rgw - Backport #68984: squid: rgw: "radosgw-admin topic list" may contain duplicated data and redundant nestingResolvedYuval LifshitzActions
Actions
Copy link
 #1

Updated by Alex Kershaw over 1 year ago

  • Affected Versions v19.1.1 added
Actions
Copy link
 #2

Updated by Alex Kershaw over 1 year ago

Meant to edit this out to avoid confusion, but "rga" is just my alias for "radosgw-admin".

Actions
Copy link
 #3

Updated by J. Eric Ivancich over 1 year ago

  • Assignee set to Yuval Lifshitz
Actions
Copy link
 #4

Updated by Yuval Lifshitz over 1 year ago

  • Tags set to notifications
Actions
Copy link
 #5

Updated by Ali Masarwa over 1 year ago

I tried recreating the issue but I couldn't reproduce it
Can I have more info about your setup?

Actions
Copy link
 #7

Updated by Alex Kershaw over 1 year ago

Apologies, I missed your request for more information. Please let me know if it is still needed. Otherwise, thanks for fixing!

Actions
Copy link
 #8

Updated by Casey Bodley over 1 year ago

  • Status changed from New to Fix Under Review
  • Assignee changed from Yuval Lifshitz to Ali Masarwa
  • Pull request ID set to 60045
Actions
Copy link
 #9

Updated by Yuval Lifshitz over 1 year ago

  • Backport set to squid
Actions
Copy link
 #10

Updated by Yuval Lifshitz over 1 year ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #11

Updated by Upkeep Bot over 1 year ago

  • Copied to Backport #68984: squid: rgw: "radosgw-admin topic list" may contain duplicated data and redundant nesting added
Actions
Copy link
 #12

Updated by Upkeep Bot over 1 year ago

  • Tags (freeform) set to backport_processed
Actions
Copy link
 #13

Updated by Yuval Lifshitz over 1 year ago

  • Status changed from Pending Backport to Resolved
Actions
Copy link
 #14

Updated by Upkeep Bot 10 months ago

  • Merge Commit set to 66bf56ec50d0e1688ffc2601a12a365d94466b90
  • Fixed In set to v19.3.0-5656-g66bf56ec50d
  • Upkeep Timestamp set to 2025-07-10T12:14:54+00:00
Actions
Copy link
 #15

Updated by Upkeep Bot 10 months ago

  • Fixed In changed from v19.3.0-5656-g66bf56ec50d to v19.3.0-5656-g66bf56ec50
  • Upkeep Timestamp changed from 2025-07-10T12:14:54+00:00 to 2025-07-14T20:10:35+00:00
Actions
Copy link
 #16

Updated by Upkeep Bot 6 months ago

  • Released In set to v20.2.0~1758
  • Upkeep Timestamp changed from 2025-07-14T20:10:35+00:00 to 2025-11-01T01:30:38+00:00
Actions
Copy link

Also available in: Atom PDF