Project

General

Profile

Actions
Copy link

Enhancement #67987

open

mgr/vol: make CloneProgressReporter figure current number of cloner threads on its own

Added by Rishabh Dave over 1 year ago. Updated 5 months ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
Rishabh Dave
Category:
-
Target version:
-
% Done:

0%

Source:
Backport:
squid,reef
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
61212
Tags (freeform):
backport_processed
Merge Commit:
089cd8ea4d66012001ec9a32661073a10a25703a
Fixed In:
v20.0.0-1612-g089cd8ea4d
Released In:
v20.2.0~530
Upkeep Timestamp:
2025-11-01T01:02:23+00:00

Description

Add code to CloneProgressReporter to detect current number of ongoing clone instead of depending on its attribute that stores value of config option max_concurrent_clones. This idea was suggested by Venky on PR 54620.

Alternate and less expensive approach is to insert code to update value of CloneProgressReporter attribute that stores value of max_concurrent_value when value of config option max_concurrent_value is changed. Any thoughts on this?

Related issues 5 (3 open — 2 closed)

Related to CephFS - Feature #61904: pybind/mgr/volumes: add more introspection for clonesPending BackportRishabh Dave

Actions
Copied to CephFS - Backport #71021: reef: mgr/vol: make CloneProgressReporter figure current number of cloner threads on its ownNewRishabh DaveActions
Copied to CephFS - Backport #71022: reef: mgr/vol: make CloneProgressReporter figure current number of cloner threads on its ownDuplicateRishabh DaveActions
Copied to CephFS - Backport #71023: squid: mgr/vol: make CloneProgressReporter figure current number of cloner threads on its ownNewRishabh DaveActions
Copied to CephFS - Backport #71024: squid: mgr/vol: make CloneProgressReporter figure current number of cloner threads on its ownDuplicateRishabh DaveActions
Actions
Copy link
 #1

Updated by Rishabh Dave over 1 year ago

  • Related to Feature #61904: pybind/mgr/volumes: add more introspection for clones added
Actions
Copy link
 #2

Updated by Rishabh Dave over 1 year ago

  • Pull request ID set to 54620
Actions
Copy link
 #3

Updated by Rishabh Dave over 1 year ago

  • Tracker changed from Bug to Enhancement
  • Regression deleted (No)
  • Severity deleted (3 - minor)
Actions
Copy link
 #4

Updated by Rishabh Dave over 1 year ago

  • Pull request ID deleted (54620)
Actions
Copy link
 #5

Updated by Rishabh Dave over 1 year ago

  • Description updated (diff)
Actions
Copy link
 #6

Updated by Venky Shankar about 1 year ago

Rishabh Dave wrote:

Add code to CloneProgressReporter to detect current number of ongoing clone instead of depending on its attribute that stores value of config option max_concurrent_clones. This idea was suggested by Venky on PR 54620.

Alternate and less expensive approach is to insert code to update value of CloneProgressReporter attribute that stores value of max_concurrent_value when value of config option max_concurrent_value is changed. Any thoughts on this?

The code does iterate the list of clones, so, given that clones are picked up in FIFO, counting the number of in-progress clones by checking the clone state and matching it to pending state would be preferred.

Actions
Copy link
 #7

Updated by Rishabh Dave about 1 year ago

  • Pull request ID set to 61212
Actions
Copy link
 #8

Updated by Rishabh Dave about 1 year ago

  • Status changed from New to Fix Under Review
Actions
Copy link
 #9

Updated by Rishabh Dave 11 months ago

  • Status changed from Fix Under Review to Pending Backport
  • Backport set to squid,reef
Actions
Copy link
 #10

Updated by Rishabh Dave 11 months ago

  • Copied to Backport #71021: reef: mgr/vol: make CloneProgressReporter figure current number of cloner threads on its own added
Actions
Copy link
 #11

Updated by Upkeep Bot 11 months ago

  • Copied to Backport #71022: reef: mgr/vol: make CloneProgressReporter figure current number of cloner threads on its own added
Actions
Copy link
 #12

Updated by Rishabh Dave 11 months ago

  • Copied to Backport #71023: squid: mgr/vol: make CloneProgressReporter figure current number of cloner threads on its own added
Actions
Copy link
 #13

Updated by Upkeep Bot 11 months ago

  • Copied to Backport #71024: squid: mgr/vol: make CloneProgressReporter figure current number of cloner threads on its own added
Actions
Copy link
 #14

Updated by Rishabh Dave 11 months ago

  • Tags (freeform) set to backport_processed
Actions
Copy link
 #15

Updated by Rishabh Dave 11 months ago

Waiting for backports of #61904 to be merged.

Actions
Copy link
 #16

Updated by Upkeep Bot 9 months ago

  • Merge Commit set to 089cd8ea4d66012001ec9a32661073a10a25703a
  • Fixed In set to v20.0.0-1612-g089cd8ea4d6
  • Upkeep Timestamp set to 2025-07-08T18:45:09+00:00
Actions
Copy link
 #17

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v20.0.0-1612-g089cd8ea4d6 to v20.0.0-1612-g089cd8ea4d66
  • Upkeep Timestamp changed from 2025-07-08T18:45:09+00:00 to 2025-07-14T15:45:28+00:00
Actions
Copy link
 #18

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v20.0.0-1612-g089cd8ea4d66 to v20.0.0-1612-g089cd8ea4d
  • Upkeep Timestamp changed from 2025-07-14T15:45:28+00:00 to 2025-07-14T21:09:53+00:00
Actions
Copy link
 #19

Updated by Upkeep Bot 5 months ago

  • Released In set to v20.2.0~530
  • Upkeep Timestamp changed from 2025-07-14T21:09:53+00:00 to 2025-11-01T01:02:23+00:00
Actions
Copy link

Also available in: Atom PDF