Project

General

Profile

Actions
Copy link

Bug #66714

closed

osd/scheduler: add perfcounter for mclock

Added by jianwei zhang over 1 year ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

100%

Source:
Backport:
reef, squid
Regression:
No
Severity:
3 - minor
Reviewed:
06/27/2024
Affected Versions:
Ceph - v19.0.0
ceph-qa-suite:
rados
Component(RADOS):
OSD
Pull request ID:
58302
Tags (freeform):
backport_processed
Merge Commit:
78e6193a15d8d44038260aec07e8d284e344aaa2
Fixed In:
v19.3.0-3935-g78e6193a15
Released In:
v20.2.0~2314
Upkeep Timestamp:
2025-11-01T01:33:12+00:00

Description

# ceph daemon osd.0 perf dump | grep mclock- -A 6
    "mclock-0": {
        "mclock_immediate_queue_len": 0,
        "mclock_client_queue_len": 0,
        "mclock_store_db_queue_len": 0,
        "mclock_recovery_queue_len": 0,
        "mclock_best_effort_queue_len": 0
    },
    "mclock-1": {
        "mclock_immediate_queue_len": 0,
        "mclock_client_queue_len": 0,
        "mclock_store_db_queue_len": 0,
        "mclock_recovery_queue_len": 0,
        "mclock_best_effort_queue_len": 0
    },
    "mclock-2": {
        "mclock_immediate_queue_len": 0,
        "mclock_client_queue_len": 0,
        "mclock_store_db_queue_len": 0,
        "mclock_recovery_queue_len": 0,
        "mclock_best_effort_queue_len": 0
    },
    "mclock-3": {
        "mclock_immediate_queue_len": 0,
        "mclock_client_queue_len": 0,
        "mclock_store_db_queue_len": 0,
        "mclock_recovery_queue_len": 0,
        "mclock_best_effort_queue_len": 0
    },
    "mclock-4": {
        "mclock_immediate_queue_len": 0,
        "mclock_client_queue_len": 0,
        "mclock_store_db_queue_len": 0,
        "mclock_recovery_queue_len": 0,
        "mclock_best_effort_queue_len": 0
    },

Subtasks 1 (0 open — 1 closed)

Bug #66758: src/common: dead loop in PerfCountersCollectionImpl::add() when adding the same logger_ptr to logger_collectionDuplicateMOHIT AGRAWAL

Actions

Related issues 3 (0 open — 3 closed)

Has duplicate RADOS - Feature #64167: osd: add mclock queue perfcounterDuplicate

Actions
Copied to RADOS - Backport #67355: squid: osd/scheduler: add perfcounter for mclockResolvedSridhar SeshasayeeActions
Copied to RADOS - Backport #67357: reef: osd/scheduler: add perfcounter for mclockResolvedSridhar SeshasayeeActions
Actions
Copy link
 #2

Updated by jianwei zhang over 1 year ago 

# ceph daemon osd.0 perf dump | grep mclock- -A 6
    "mclock-0": {
        "mclock_immediate_queue_len": 0,
        "mclock_client_queue_len": 0,
        "mclock_store_db_queue_len": 0,
        "mclock_recovery_queue_len": 3,
        "mclock_best_effort_queue_len": 5
    },
    "mclock-1": {
        "mclock_immediate_queue_len": 0,
        "mclock_client_queue_len": 0,
        "mclock_store_db_queue_len": 0,
        "mclock_recovery_queue_len": 2,
        "mclock_best_effort_queue_len": 1
    },
    "mclock-2": {
        "mclock_immediate_queue_len": 0,
        "mclock_client_queue_len": 2,
        "mclock_store_db_queue_len": 3,
        "mclock_recovery_queue_len": 7,
        "mclock_best_effort_queue_len": 2
    },
    "mclock-3": {
        "mclock_immediate_queue_len": 0,
        "mclock_client_queue_len": 0,
        "mclock_store_db_queue_len": 0,
        "mclock_recovery_queue_len": 2,
        "mclock_best_effort_queue_len": 1
    },
    "mclock-4": {
        "mclock_immediate_queue_len": 0,
        "mclock_client_queue_len": 0,
        "mclock_store_db_queue_len": 0,
        "mclock_recovery_queue_len": 3,
        "mclock_best_effort_queue_len": 25
    },
[root@zjw-cmain-dev build]# ceph daemon
Actions
Copy link
 #3

Updated by jianwei zhang over 1 year ago

+1 when entering the team, -1 when leaving the team

Actions
Copy link
 #4

Updated by jianwei zhang over 1 year ago 

    "mclock-shard-queue-0": {
        "mclock_immediate_queue_len": 0,
        "mclock_client_queue_len": 0,
        "mclock_store_db_queue_len": 0,
        "mclock_recovery_queue_len": 1,
        "mclock_best_effort_queue_len": 3,
        "mclock_all_type_queue_len": 4
    },
    "mclock-shard-queue-1": {
        "mclock_immediate_queue_len": 0,
        "mclock_client_queue_len": 0,
        "mclock_store_db_queue_len": 0,
        "mclock_recovery_queue_len": 0,
        "mclock_best_effort_queue_len": 24,
        "mclock_all_type_queue_len": 24
    },
    "mclock-shard-queue-2": {
        "mclock_immediate_queue_len": 0,
        "mclock_client_queue_len": 0,
        "mclock_store_db_queue_len": 0,
        "mclock_recovery_queue_len": 0,
        "mclock_best_effort_queue_len": 4,
        "mclock_all_type_queue_len": 4
    },
    "mclock-shard-queue-3": {
        "mclock_immediate_queue_len": 0,
        "mclock_client_queue_len": 0,
        "mclock_store_db_queue_len": 0,
        "mclock_recovery_queue_len": 0,
        "mclock_best_effort_queue_len": 0,
        "mclock_all_type_queue_len": 0
    },
    "mclock-shard-queue-4": {
        "mclock_immediate_queue_len": 0,
        "mclock_client_queue_len": 0,
        "mclock_store_db_queue_len": 0,
        "mclock_recovery_queue_len": 0,
        "mclock_best_effort_queue_len": 0,
        "mclock_all_type_queue_len": 0
    },
Actions
Copy link
 #5

Updated by Sridhar Seshasayee over 1 year ago

  • Status changed from New to Fix Under Review
Actions
Copy link
 #6

Updated by MOHIT AGRAWAL over 1 year ago

  • Subtask #66758 added
Actions
Copy link
 #7

Updated by Radoslaw Zarzynski over 1 year ago

scrub note: under review.

Actions
Copy link
 #8

Updated by Laura Flores over 1 year ago

scrub note: ready for QA

Actions
Copy link
 #10

Updated by Radoslaw Zarzynski over 1 year ago

scrub note: asked about backporting in the PR. Let's keep the tracker open for some time.

Actions
Copy link
 #11

Updated by jianwei zhang over 1 year ago

need backports

Actions
Copy link
 #12

Updated by Sridhar Seshasayee over 1 year ago

  • Status changed from Fix Under Review to Pending Backport
  • Backport set to reef, squid
Actions
Copy link
 #13

Updated by Upkeep Bot over 1 year ago

  • Copied to Backport #67355: squid: osd/scheduler: add perfcounter for mclock added
Actions
Copy link
 #14

Updated by Upkeep Bot over 1 year ago

  • Copied to Backport #67357: reef: osd/scheduler: add perfcounter for mclock added
Actions
Copy link
 #15

Updated by Upkeep Bot over 1 year ago

  • Tags (freeform) set to backport_processed
Actions
Copy link
 #16

Updated by Neha Ojha over 1 year ago

  • Has duplicate Feature #64167: osd: add mclock queue perfcounter added
Actions
Copy link
 #17

Updated by Sridhar Seshasayee over 1 year ago

  • Status changed from Pending Backport to Resolved
Actions
Copy link
 #18

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to 78e6193a15d8d44038260aec07e8d284e344aaa2
  • Fixed In set to v19.3.0-3935-g78e6193a15d
  • Upkeep Timestamp set to 2025-07-10T23:09:36+00:00
Actions
Copy link
 #19

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v19.3.0-3935-g78e6193a15d to v19.3.0-3935-g78e6193a15
  • Upkeep Timestamp changed from 2025-07-10T23:09:36+00:00 to 2025-07-14T22:42:36+00:00
Actions
Copy link
 #20

Updated by Upkeep Bot 5 months ago

  • Released In set to v20.2.0~2314
  • Upkeep Timestamp changed from 2025-07-14T22:42:36+00:00 to 2025-11-01T01:33:12+00:00
Actions
Copy link

Also available in: Atom PDF