Actions
Bug #66708
openosd: move DeleteSome behavior out of PeeringState
% Done:
0%
Source:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Tags (freeform):
Merge Commit:
Fixed In:
Released In:
Upkeep Timestamp:
Description
All PeeringState is really doing here is remembering next. Moving this behavior out of PeeringState removes the only PeeringListener callback which needs to do synchronous IO (the list_objects call needed to return next). This is a worthwhile simplification anyway, but it's a particularly big win for crimson where we don't want to yield during peering events.
Updated by Radoslaw Zarzynski over 1 year ago
scrub note: is a progress on this?
Updated by Samuel Just over 1 year ago
It's on my list, but it's not at the top as it's not actually causing incorrect crimson or classic behavior. It's here because a comment in https://github.com/ceph/ceph/pull/58464/files references it as a future improvement that would allow us to drop the interruptor::async wrapper when processing peering events.
Actions