Bug #65970
closedreef: qa: AttributeError: 'CapTester' object has no attribute 'test_set'
0%
Description
2024-05-10T19:41:25.632 INFO:tasks.cephfs_test_runner:test_single_path_rootsquash (tasks.cephfs.test_admin.TestFsAuthorize) ... ERROR 2024-05-10T19:41:25.632 INFO:tasks.cephfs_test_runner: 2024-05-10T19:41:25.632 INFO:tasks.cephfs_test_runner:====================================================================== 2024-05-10T19:41:25.632 INFO:tasks.cephfs_test_runner:ERROR: test_single_path_rootsquash (tasks.cephfs.test_admin.TestFsAuthorize) 2024-05-10T19:41:25.632 INFO:tasks.cephfs_test_runner:---------------------------------------------------------------------- 2024-05-10T19:41:25.633 INFO:tasks.cephfs_test_runner:Traceback (most recent call last): 2024-05-10T19:41:25.633 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/github.com_batrick_ceph_3b85461ef118bad87f5734a2291b30a45f58a7fc/qa/tasks/cephfs/test_admin.py", line 1320, in test_single_path_rootsquash 2024-05-10T19:41:25.633 INFO:tasks.cephfs_test_runner: self.captester.conduct_neg_test_for_chown_caps() 2024-05-10T19:41:25.633 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/github.com_batrick_ceph_3b85461ef118bad87f5734a2291b30a45f58a7fc/qa/tasks/cephfs/caps_helper.py", line 367, in conduct_neg_test_for_chown_caps 2024-05-10T19:41:25.633 INFO:tasks.cephfs_test_runner: self._conduct_neg_test_for_root_squash_caps(cmdargs, sudo_write) 2024-05-10T19:41:25.633 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/github.com_batrick_ceph_3b85461ef118bad87f5734a2291b30a45f58a7fc/qa/tasks/cephfs/caps_helper.py", line 352, in _conduct_neg_test_for_root_squash_caps 2024-05-10T19:41:25.633 INFO:tasks.cephfs_test_runner: for mount, path, data in self.test_set: 2024-05-10T19:41:25.633 INFO:tasks.cephfs_test_runner:AttributeError: 'CapTester' object has no attribute 'test_set'
/teuthology/pdonnell-2024-05-10_18:37:52-fs:functional-wip-pdonnell-testing-20240509.171335-reef-debug-distro-default-smithi/7701608/teuthology.log
caused by https://github.com/ceph/ceph/pull/54942
Updated by Rishabh Dave over 1 year ago
- Status changed from New to Fix Under Review
Updated by Rishabh Dave over 1 year ago ยท Edited
The issue originates in _conduct_neg_test_for_root_squash_caps method which is located in qa/tasks/cephfs/caps_helper.py@. It was backported in commit 59c9104(1) with modifications instead of backporting along all commits that were need. Now that those commmits have been backported here(2), this method is broken and required modifications again. This is a direct commit to Reef branch since it's a direct fix and not a backport/cherry-pick.
Along with this I've spent some more time on this ticket to bring the caps_helper on Reef branch close to caps_helper from main branch as much as possible, so that such bugs can prevented in future.
(1) https://github.com/ceph/ceph/commit/59c9104c54d64e449062d350346b33ad0b3371c9
(2) https://github.com/ceph/ceph/pull/54942
Updated by Venky Shankar over 1 year ago
Rishabh Dave wrote in #note-4:
The issue originates in
_conduct_neg_test_for_root_squash_capsmethod which is located in qa/tasks/cephfs/caps_helper.py@. It was backported in commit 59c9104(1) with modifications instead of backporting along all commits that were need. Now that those commmits have been backported here(2), this method is broken and required modifications again. This is a direct commit to Reef branch since it's a direct fix and not a backport/cherry-pick.Along with this I've spent some more time on this ticket to bring the caps_helper on Reef branch close to caps_helper from main branch as much as possible, so that such bugs can prevented in future.
(1) https://github.com/ceph/ceph/commit/59c9104c54d64e449062d350346b33ad0b3371c9
(2) https://github.com/ceph/ceph/pull/54942
But, why are we seeing this failure now, esp. since the test run[*] was approved?
[*]: https://github.com/ceph/ceph/pull/54942#pullrequestreview-1996016473
Updated by Venky Shankar over 1 year ago
- Status changed from Fix Under Review to Resolved
Updated by Upkeep Bot 9 months ago
- Merge Commit set to 42422ce6dfa52d4313de38f10d9624e7ff2652d6
- Fixed In set to v18.2.4-1142-g42422ce6dfa
- Released In set to v18.2.5~285
- Upkeep Timestamp set to 2025-06-30T19:34:13+00:00